From: Guenter Roeck <linux@roeck-us.net>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Phil Elwell <phil@raspberrypi.org>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] hwmon: Add RPi PoE HAT fan driver
Date: Sun, 2 Sep 2018 07:23:41 -0700 [thread overview]
Message-ID: <99ca4f6d-d2b2-36e7-9f27-189df379cfaf@roeck-us.net> (raw)
In-Reply-To: <1535887251-29515-1-git-send-email-stefan.wahren@i2se.com>
On 09/02/2018 04:20 AM, Stefan Wahren wrote:
> This series is an early stage of the hwmon driver for the fan on the
> Raspberry Pi Power over Ethernet HAT [1]. At the end this should use a
> Device Tree Overlay.
>
> Changes by Stefan based on [2]:
> - reformat the downstream patches for submission
> - drop reboot notification
> - fix remaining checkpatch issues
> - add COMPILE_TEST to Kconfig
>
> The driver is mostly copy & paste from pwm-fan, which isn't good. Personally
> i see two options:
>
> 1) integrate the driver function into the pwm-fan driver (new compatible)
> 2) implement the core function as a PWM driver and use the pwm-fan driver on top
>
I don't really see the point of thise driver. Why not implement either of those ?
2) sounds like a perfect fit to me.
Guenter
> [1] - https://www.raspberrypi.org/products/poe-hat/
> [2] - https://github.com/raspberrypi/linux/commit/0f937c8dc3201ebffa6c617c616fd7c65db65959
>
> Serge Schneider (2):
> dt-bindings: hwmon: Add RPi PoE HAT documentation
> hwmon: Add RPi PoE HAT fan driver
>
> .../devicetree/bindings/hwmon/rpi-poe-fan.txt | 55 +++
> Documentation/hwmon/rpi-poe-fan | 15 +
> drivers/hwmon/Kconfig | 11 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/rpi-poe-fan.c | 414 +++++++++++++++++++++
> include/soc/bcm2835/raspberrypi-firmware.h | 2 +
> 6 files changed, 498 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/rpi-poe-fan.txt
> create mode 100644 Documentation/hwmon/rpi-poe-fan
> create mode 100644 drivers/hwmon/rpi-poe-fan.c
>
next prev parent reply other threads:[~2018-09-02 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 11:20 Stefan Wahren
2018-09-02 11:20 ` [PATCH RFC 1/2] dt-bindings: hwmon: Add RPi PoE HAT documentation Stefan Wahren
2018-09-02 11:20 ` [PATCH RFC 2/2] hwmon: Add RPi PoE HAT fan driver Stefan Wahren
2018-09-02 14:23 ` Guenter Roeck [this message]
2018-09-02 16:26 ` [PATCH RFC 0/2] " Stefan Wahren
2018-09-02 16:49 ` Guenter Roeck
2018-09-02 17:13 ` Stefan Wahren
2018-09-03 18:31 ` Florian Fainelli
2018-09-03 18:55 ` Stefan Wahren
2018-09-03 19:05 ` Serge Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ca4f6d-d2b2-36e7-9f27-189df379cfaf@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=phil@raspberrypi.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®