From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755106AbcIJHUk (ORCPT ); Sat, 10 Sep 2016 03:20:40 -0400 Received: from mout.web.de ([217.72.192.78]:60090 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbcIJHUh (ORCPT ); Sat, 10 Sep 2016 03:20:37 -0400 Subject: [PATCH 4/5] ATM-nicstar: Refactor a kmalloc() call in ns_init_card() To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <99cb1cdf-f2ab-f703-d214-cc0cc26c2668@users.sourceforge.net> Date: Sat, 10 Sep 2016 09:20:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:v6FCyrPu56KJS3XRd2Dw51+KFV5aOi91FGVC7kjY3qZNUw9JTGF 6O2COGOXbLFr++wJNOqr1rh2uJKGsu8L18sfBado3CZhCNDwG4R2KyzNtEdUfe7Vfgmwihh jH9y1xo8rIGy9sVHhaFDMvuVHxlKiJhJVceShsQ7KxWG8xRM36GvzJxvZlixeTlnF+arzwV /A6IXkGg4RTJsYswwE1fw== X-UI-Out-Filterresults: notjunk:1;V01:K0:lf0u03mVuks=:J45zvj/OYqeYLxJD8FO9G9 xaiRRk620EOQbHOm7PAwVfq7O3OyGw+r1UP41ILvdOsZILC3e3JKssdLzRQYlu1QtjmRa9BPs BMwhmvaNmtJP0JhPO1ngp70tRe6h5yJ1wNmpXfGMNDf9L7ThWeejIpEf/VO/ZWswU/Pzb9JvH rx0KbiCvbS1HGaFpwE3mn4jmU+nYHjAdvsrLbfxzNSt5zLG7iPrb8Xe44bR1HBuqYnFUeK4Ci YHYjyEzSED1JzXtgpGSQNRHmnvvY37KoFiwFSsTOVdlWDGvzb2NM7Jg37ofm7yuxG4JezYX/+ ClAOF/j3xZKMo6IWYlAHUXt4mLLZeBFoc/cbjPKX4o8djAfr3A+pps+UGGeFVvFZ61i9JswQk hoUUpM58DAks2Zs5lnkLYjj72TGalLIDtf1yRYd0ELgCBi6wMBsk/h5yV1ljAXFOpNbGo+SZw NZx6DvREWbYJQnG460Z/N9j+aXMSqo4qiwKdshBlZe5nqpXLz8/8oAeSRB/YbVxAlOi/OTRMz pUU9n23Xkp0JjfIUsIkiM01OkGkdQLwkgGRj8CDTR8+bT5PWjRuWWov6QMx10E9ZGLlWnF0N/ 46WTPstotRkVf4jeH0/zTPYyvAoR03EKD9hhgIq9+NVUMy3H+44IPSrt0wF/v7pNBp9+hsBfQ PB1+LxYibYi8DSYPS/k/SyGyhMHT+7U/NRNjtEYeMBNFzrt1JA0WFKNYIGZOatXrjEBn2FQxg jAONRjIuJc31jjsglllSpEvkHPg6cexrCf59P+oIjaP3z/sFrhSrUamul36ZJRH8TgJ4cXB9Y 0yGLtF3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 08:48:17 +0200 * The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move an assignment for a local variable to a separate statement in this function. * Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/nicstar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index ef977bf..04f5781 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -370,7 +370,8 @@ static int ns_init_card(int i, struct pci_dev *pcidev) return error; } - if ((card = kmalloc(sizeof(ns_dev), GFP_KERNEL)) == NULL) { + card = kmalloc(sizeof(*card), GFP_KERNEL); + if (!card) { printk ("nicstar%d: can't allocate memory for device structure.\n", i); -- 2.10.0