From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F671A264A for ; Thu, 19 Dec 2024 19:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734635201; cv=none; b=mA+S3hHaQWPNSXlNx3JTIbO/XqpR2uAzqIjtzSsNo5bUAO8yBiiaJR69tZLBwia4hkxYm3RRwvV7WBKPOzajmu8ZwL5+cYNawKCFVr7QEEVl9g3IUUIkj/VTFcsrj+eo/E+9AmbftL3uIq/ZTqIXsKKegK3k64GMm2K3aknzcFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734635201; c=relaxed/simple; bh=miKz4Lq8b27Bo3nvZE/oEwtbz8gqti8YbPGWfvTe/P8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pf2T858MNRPbBetXHasDbInZnH6O+4qFqGi21nuIHA2FiPgGHfnvvN3S+WF5ezSSGl44E233gR7lY8PlSpw2CLP7ExPDonaehZAt/pQtXo0QhLhqDJkYbojY75ETcxx5BlPYeOoX3pMOliGkEceknhaUQM04KwSKQhs61qb6Yc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TyfdPLYK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TyfdPLYK" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJBeE5I029009 for ; Thu, 19 Dec 2024 19:06:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UWZ6vfFZXZOnn8Rj5pWSW2pSt+O0bU6UJnoyNmvkHEI=; b=TyfdPLYK7xrCUmiv YL0g9YeZeo92wDd7G3lM5IZPWHtdXeLQuPiVzQLsPNV+JXNSmlOp2HfvThIaiFpn oCK7sqvjM/oPWbdXoKdjiGSvSXoDQJ/7H3ejcHnRFpQlCeNf9ljdOZ78912H44lm Ae35tIaZCRwv+7ZgcDAA/uy6pUcuO5CrU7mlPFASmcoADbEyGeYD7/utC9oW6V2v 7HoK4GVCYjzgfrnLaROih1wxEAQuSuKJTQIdv8PkWIPi1e4B0k7U0unTHzNCCCo2 pRez/pTyxoakCtMVb0/oLAHLEcG4/HZUqRMY1SUXuHGgA9nLBJ8GyHQynIB6XFdL 2J0Q6Q== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43mjtes6am-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 19 Dec 2024 19:06:39 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-467a97dec51so295811cf.0 for ; Thu, 19 Dec 2024 11:06:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734635198; x=1735239998; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UWZ6vfFZXZOnn8Rj5pWSW2pSt+O0bU6UJnoyNmvkHEI=; b=bVllKXKAxP8c3OV4OH1GsivZk/He6unUCVvtM0X+RFUVLx15BIQ4EdkDHMb5KjXcht yODtNN8pEPPPfppY/bkSMAr/X/Bumr4PVYPQ+nsU/lcW5ul/30uAjr2SMHR9bcEFt+Ia iAvIhyiTt7RUq6NRIwbKlnbSmSKT3rKeAsedyACQRGIdYcVqvL95uBHR/JYy3fnAVKEX hwZWzw8izJfw9TJkSp5ssG0H2ejxeUpvZspeTVjUmnyY0D+oHhQVugPr4U9GZSDYE5yo Kafsps9GlbKOJysr7zR10SOp8dMjLgEdP2GQ8HxYd1dZoOn0QMdLEe1O3ZzXrYP73VAY 8QUA== X-Forwarded-Encrypted: i=1; AJvYcCWVF9Fg2ulBOeysaUaQv5QAsJPfWi6efZhdMYaxfYLmsUedwqD4uN6dqU93Ogj89Il5wWMUIjV4bdJ/4dY=@vger.kernel.org X-Gm-Message-State: AOJu0YzSaa1KO227G75VVTj0UW5+IC/P2Y4J5mENhLC30SVecrfnEDCf fWeukbRAjeIvi4kJ/esK4JEKRQxHKiTFUf8j8AHoN42gxxXko38a48AFpFXsf8tioKVITecr6Vp wVX9gtsHi1Jn88FVqbdYT6RAypDQPSMaYsMXe34Sp6Vh931S7xHe1kSgAYy57eNo= X-Gm-Gg: ASbGnctRvJkjmu1AJJxgVe0hoAuvVdjEzpcKhxrlfH9j4Ux7wzwmVQyevUDU/lSAOy/ ClgA6N877FB7KhCkRvuKj7Y/pZ2NpNk2wbspeeADsAoYC1zdRxgOTWBCYbsx2MqdUMzs5Vx+ypA lBl1VlXg+X95G9VFNchezeS/poLNZdxUVu+JvzOj45uR+RlzVp68Y0Dxm2Tvmi18FdvuScv+fe2 lBZ7LcAJCF+eFMb5xsEtEQ0F7gIyIm/SaqKmLO06QlRiU0nn4r1VEaH7T4u3nRR02bBvKLiYu6G lf+Q2kjD8BsaaO/rlHNO+wmEFxmT0EWJ+Oo= X-Received: by 2002:a05:622a:586:b0:461:4467:14bb with SMTP id d75a77b69052e-46a4a8b7e47mr855001cf.2.1734635198140; Thu, 19 Dec 2024 11:06:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7a+DlVQKkqn/PJw0dZDP1rNN4h3Og1DclMhN5A+YbI0DOWhNTu1aJqt/TQmvgKz06Gf28kg== X-Received: by 2002:a05:622a:586:b0:461:4467:14bb with SMTP id d75a77b69052e-46a4a8b7e47mr854701cf.2.1734635197741; Thu, 19 Dec 2024 11:06:37 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e8954bfsm96578066b.60.2024.12.19.11.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 11:06:37 -0800 (PST) Message-ID: <99cf5f7e-43f6-4ac4-a4a2-dc731b695572@oss.qualcomm.com> Date: Thu, 19 Dec 2024 20:06:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 4/4] arm64: dts: qcom: qcs6490-rb3gen2-vision-mezzanine: Add vision mezzanine To: Vladimir Zapolskiy , Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Konrad Dybcio References: <20241217140656.965235-1-quic_vikramsa@quicinc.com> <20241217140656.965235-5-quic_vikramsa@quicinc.com> <22479c27-9265-4994-8974-9739ecbae5ee@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <22479c27-9265-4994-8974-9739ecbae5ee@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: dGIDp4cDJZnEt43k24EFxESQ4GNJE3nw X-Proofpoint-ORIG-GUID: dGIDp4cDJZnEt43k24EFxESQ4GNJE3nw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 mlxlogscore=927 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412190152 On 17.12.2024 3:40 PM, Vladimir Zapolskiy wrote: > On 12/17/24 16:06, Vikram Sharma wrote: >> The Vision Mezzanine for the RB3 ships with an imx577 camera sensor. >> Enable the IMX577 on the vision mezzanine. >> >> An example media-ctl pipeline for the imx577 is: >> >> media-ctl --reset >> media-ctl -v -V '"imx577 '19-001a'":0[fmt:SRGGB10/4056x3040 field:none]' >> media-ctl -V '"msm_csiphy3":0[fmt:SRGGB10/4056x3040]' >> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' >> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' >> media-ctl -l '"msm_csiphy3":1->"msm_csid0":0[1]' >> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' >> >> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 >> >> Signed-off-by: Hariram Purushothaman >> Signed-off-by: Vikram Sharma >> Signed-off-by: Trishansh Bhardwaj >> Reviewed-by: Bryan O'Donoghue >> Reviewed-by: Konrad Dybcio >> --- [...] >> +        rst-pins { >> +            pins = "gpio78"; >> +            function = "gpio"; >> +            drive-strength = <2>; >> +            bias-pull-down; >> +            output-low; >> +        }; > > I have doubts that it's proper to embed a reset gpio into driver's > pinctrl suspend/resume power management. > > Konrad, can you please confirm that it's really accepted? > > I'd rather ask to remove this reset pin control. There's certainly some appearances of this in the tree. You could make the argument that it makes sense to prevent misconfiguration (i.e. the bootloader may set the pin in input mode), but then the counter argument is that the (Linux) gpiod APIs request OUT_LOW/HIGH, and we would expect that the driver uses that if the GPIO is requested through e.g. reset-gpios. I'm not particularly sure what to recommend here. Krzysztof? Konrad