From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Sean Christopherson <sean.j.christopherson@intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Haiwei Li <lihaiwei@tencent.com>
Subject: Re: [PATCH v2 5/5] KVM: VMX: Handle preemption timer fastpath
Date: Thu, 23 Apr 2020 11:40:24 +0200 [thread overview]
Message-ID: <99d81fa5-dc37-b22f-be1e-4aa0449e6c26@redhat.com> (raw)
In-Reply-To: <1587632507-18997-6-git-send-email-wanpengli@tencent.com>
On 23/04/20 11:01, Wanpeng Li wrote:
> +bool kvm_lapic_expired_hv_timer_fast(struct kvm_vcpu *vcpu)
> +{
> + struct kvm_lapic *apic = vcpu->arch.apic;
> + struct kvm_timer *ktimer = &apic->lapic_timer;
> +
> + if (!apic_lvtt_tscdeadline(apic) ||
> + !ktimer->hv_timer_in_use ||
> + atomic_read(&ktimer->pending))
> + return 0;
> +
> + WARN_ON(swait_active(&vcpu->wq));
> + cancel_hv_timer(apic);
> +
> + ktimer->expired_tscdeadline = ktimer->tscdeadline;
> + kvm_inject_apic_timer_irqs_fast(vcpu);
> +
> + return 1;
> +}
> +EXPORT_SYMBOL_GPL(kvm_lapic_expired_hv_timer_fast);
Please re-evaluate if this is needed (or which parts are needed) after
cleaning up patch 4. Anyway again---this is already better, I don't
like the duplicated code but at least I can understand what's going on.
Paolo
next prev parent reply other threads:[~2020-04-23 9:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 9:01 [PATCH v2 0/5] KVM: VMX: Tscdeadline timer emulation fastpath Wanpeng Li
2020-04-23 9:01 ` [PATCH v2 1/5] KVM: LAPIC: Introduce interrupt delivery fastpath Wanpeng Li
2020-04-23 9:25 ` Paolo Bonzini
2020-04-23 9:35 ` Wanpeng Li
2020-04-23 9:39 ` Paolo Bonzini
2020-04-23 9:44 ` Wanpeng Li
2020-04-23 9:52 ` Paolo Bonzini
2020-04-23 9:01 ` [PATCH v2 2/5] KVM: X86: Introduce need_cancel_enter_guest helper Wanpeng Li
2020-04-23 9:01 ` [PATCH v2 3/5] KVM: VMX: Introduce generic fastpath handler Wanpeng Li
2020-04-23 9:01 ` [PATCH v2 4/5] KVM: X86: TSCDEADLINE MSR emulation fastpath Wanpeng Li
2020-04-23 9:37 ` Paolo Bonzini
2020-04-23 9:54 ` Wanpeng Li
2020-04-23 10:28 ` Paolo Bonzini
2020-04-23 9:01 ` [PATCH v2 5/5] KVM: VMX: Handle preemption timer fastpath Wanpeng Li
2020-04-23 9:40 ` Paolo Bonzini [this message]
2020-04-23 9:56 ` Wanpeng Li
2020-04-23 10:29 ` Paolo Bonzini
2020-04-24 6:38 ` Wanpeng Li
2020-04-26 7:38 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d81fa5-dc37-b22f-be1e-4aa0449e6c26@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=lihaiwei@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®