From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B6CC4320A for ; Wed, 25 Aug 2021 09:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C31261153 for ; Wed, 25 Aug 2021 09:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239598AbhHYJz5 (ORCPT ); Wed, 25 Aug 2021 05:55:57 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:14418 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236737AbhHYJz4 (ORCPT ); Wed, 25 Aug 2021 05:55:56 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Gvh7q53XLzbddf; Wed, 25 Aug 2021 17:51:19 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 25 Aug 2021 17:55:02 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 25 Aug 2021 17:55:02 +0800 Subject: Re: [PATCH 4/4] mm: kfence: Only load kfence_test when kfence is enabled To: Alexander Potapenko CC: Russell King , Marco Elver , Dmitry Vyukov , Linux ARM , LKML , kasan-dev , Andrew Morton References: <20210825092116.149975-1-wangkefeng.wang@huawei.com> <20210825092116.149975-5-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: <99daf260-76af-8316-fa9a-a649c8a8d1ab@huawei.com> Date: Wed, 25 Aug 2021 17:55:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/25 17:31, Alexander Potapenko wrote: > On Wed, Aug 25, 2021 at 11:17 AM Kefeng Wang wrote: >> Provide kfence_is_enabled() helper, only load kfence_test module >> when kfence is enabled. > What's wrong with the current behavior? > I think we need at least some way to tell the developer that KFENCE > does not work, and a failing test seems to be the perfect one. If the kfence is not enabled, eg kfence.sample_interval=0, kfence_test spend too much time, and all tests will fails. It is meaningless. so better to just skip it ;) >> diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c >> index eb6307c199ea..4087f9f1497e 100644 >> --- a/mm/kfence/kfence_test.c >> +++ b/mm/kfence/kfence_test.c >> @@ -847,6 +847,8 @@ static void unregister_tracepoints(struct tracepoint *tp, void *ignore) >> */ >> static int __init kfence_test_init(void) >> { >> + if (!kfence_is_enabled()) Add a print info here? >> + return 0; >> /* >> * Because we want to be able to build the test as a module, we need to >> * iterate through all known tracepoints, since the static registration >> -- >> 2.26.2 >> >> -- >> You received this message because you are subscribed to the Google Groups "kasan-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20210825092116.149975-5-wangkefeng.wang%40huawei.com. > >