From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011032.outbound.protection.outlook.com [52.101.62.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1889A3019BA; Fri, 21 Nov 2025 06:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763705736; cv=fail; b=WIQ1rEsul0EjwdZeRwtE8ySKXSrTn6VTbv7lywyC0b3dHwncgTNZaBG8evVqKLW4HSZq+kqCEPokM7kBxaGwxl1aXY+lcsOIhn7xXbzuXNpfTph8xERZHma+/Q/u4HREOXN0LEcc88hABOaDjXWn1yy7WSI3+dCVMY94YRbbj/c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763705736; c=relaxed/simple; bh=DGCuOKXwOqJynI01GaOPbKMvNBMGFdWiyQE/Tv4ZTTM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=kIdAUE85We5CzwV74qOdU4jEgaSdwI7ExjWbowfZHdsWheOok/F0B5JyLFEmPP3ljtAIGnVJiXIhO9gtf9vySqIV2noEkN5TfENRBl4ONyxA+7bguVGFFKjG0Ing8kphJNANix1X9lT6J6BzeXLNDD0B4FJs4/easWJrNEx7mNQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ThlUUDdW; arc=fail smtp.client-ip=52.101.62.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ThlUUDdW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HcHXVul5kbglMDdpLMj+BK4+xPj3H7a7SgIkGq4tnvbnqlRKwmcNujf2OjeRM0Occvthh4TmnU6Z58AN/7JgxaFp1F/e/7qVa1xBYmG5DXWvKmKGbfXUsoz+1zZG7wlL2BvV/NB6XZ/WnrTZbhK3fyNWaDq9TeLTVCCXlrNMv2jlY5Rj/bFNOMiXVKjIbcRyoKxsoWxzDuPVVWCc8p/BQNJwIfUlPJ+huUbccLeSJChLB490YMha/oITU8eCdaMsqQiwfIgv8/yDT1MKRVxkFlGzPVOr69FsK9ohw5dS/fEbVEUQIfq8T/4aAIAH9kZohEVRYRO7t5PA3Rh2gEz3Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+y6lrQA/QuFX1k5mPJEaAt45DTVBEnGWrI1nHorFwCg=; b=yK9ESlsI1bMkcyFnV0lVrw8+CyxX70THgiEd7DBEzoUACwhGM5ZPEhrmYER/Nqm0duY3igkC3HM5nE/55QsoCNp8k5KSzcEa/dRZ/Q5pTUZD05U+UUg6WgU9gEyx4sqIdoRr/gPYqyxgrM/T8vsuN68ozb1w+7o2NJUNdH+7AlxTyb6yYRmWPyudNQcBE7y0vbA6NbBtCReX5r9He26lvlDMYeXMIx6CF4orj3R4pppCDknLm7Xj0An9sog7TMgg8QFaSN5OPb8Kf8NIlhCPPkBennQjNL2xGNrhQGlzZ142Hpms1Lb0oI09ftEsdCyiz3DVpO2R4cnWQIlHwCyhLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+y6lrQA/QuFX1k5mPJEaAt45DTVBEnGWrI1nHorFwCg=; b=ThlUUDdW0aWXnr3wxfGTacCs7yPQ8gs41hD3Y9lay6AfwxEHm1BPAK03MbxPSaPIQ2yR5MKlKKzwshUzX0M0NBBUQeS/H9HVezWS7HZ7Oo4z9cAWmcGtYbcu6ZBaT6kYXXBqR6Dd2OhOddqxXbVF5XJtM1iUsiPWBWH/MqpPEmg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MW4PR12MB7465.namprd12.prod.outlook.com (2603:10b6:303:212::18) by MN2PR12MB4206.namprd12.prod.outlook.com (2603:10b6:208:1d5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.11; Fri, 21 Nov 2025 06:15:31 +0000 Received: from MW4PR12MB7465.namprd12.prod.outlook.com ([fe80::6b00:b9eb:486a:f10b]) by MW4PR12MB7465.namprd12.prod.outlook.com ([fe80::6b00:b9eb:486a:f10b%4]) with mapi id 15.20.9343.011; Fri, 21 Nov 2025 06:15:31 +0000 Message-ID: <99e1a117-d6b6-44bb-a5f4-77a36b266b69@amd.com> Date: Fri, 21 Nov 2025 11:45:22 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] mm/khugepaged: map dirty/writeback pages failures to EAGAIN To: "David Hildenbrand (Red Hat)" , Lance Yang , Dev Jain Cc: Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Barry Song , Andrew Morton , Steven Rostedt , Lorenzo Stoakes , Masami Hiramatsu , Mathieu Desnoyers , Zach O'Keefe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org References: <20251120065043.41738-6-shivankg@amd.com> <20251120065043.41738-10-shivankg@amd.com> <6c1d6b80-d290-4110-9a49-53e7404136bc@arm.com> <33476cb4-318b-49db-9cc1-a354eca9e883@amd.com> <81e34d93-9031-4840-a0d0-56d488f3bc17@kernel.org> Content-Language: en-US From: "Garg, Shivank" In-Reply-To: <81e34d93-9031-4840-a0d0-56d488f3bc17@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN4PR01CA0114.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:266::14) To MW4PR12MB7465.namprd12.prod.outlook.com (2603:10b6:303:212::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR12MB7465:EE_|MN2PR12MB4206:EE_ X-MS-Office365-Filtering-Correlation-Id: 2548558e-35a3-42a4-4f39-08de28c55fa5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?STFJY2JYOWoxSGczSmhUSGRKT3g3a2c1QVIrczZRWHE4WTJKYWFYRFFoanRD?= =?utf-8?B?bEJGSlV4L1dHRVFkRVUrREhOMmt6RzFRMGtvTzhEOS8yWlF6eUxzbkVETkd0?= =?utf-8?B?WjUzeEJLZ2RqQmg2SjFGS1c1YXF1QWo1WUgwSVV4QWVLRTNmOGgrN3pYRW5q?= =?utf-8?B?VjlKdDRqZlBhY1lwNnc1RHdmVmZtMU9XVnVmV3ZlcUlHbkVtZzkya2hUdmEz?= =?utf-8?B?U2RjaWhYZktkcHhqSlFFd05NMFgvVUl6ZUp0elQxclJnZU5qV2kwTHRUVW0z?= =?utf-8?B?ajBDMXJTQXJRYkp3RVZ6aENsS2JKb01wWHdNNmFMKzU5alRVdEFhMDErTEEx?= =?utf-8?B?TDhmcWtsVVI5Tks0bi8zMDRjajlvbUZibUR0bjZkdUtIV1lQaVBqRERlRjNy?= =?utf-8?B?TXZlUEhkRlpKMEZhUmxNcXNtWVVQbmR4MFhGUkRFQ01rYzQxVnYrUU1aaEZ1?= =?utf-8?B?Q3QrRGhVVERkb2YvOHJ4UzN1NXl1YnFnak9VOU9yN1B6TUhGK2tlSzZMQU8y?= =?utf-8?B?STJac0lDTDBNSDhxRTZqVTdHL0dsd1RWZmZVOVRTbFo0akQ1UEdISVdYU0tJ?= =?utf-8?B?V2ZpVnJSczZUUlRPTHVhOHNNci9KMWkzN2YzaGRpOWVtVlE2TVYwdnVWa3BZ?= =?utf-8?B?SzBPaE12SVRPYjAzTDhoSWNvaUZiTEtXM2dDNU16bXpXa1U5dXZOOXJMTWJU?= =?utf-8?B?MlRZN3FDM1FuaFo3bWRLNk1mWVVBY04xZStzcklSN09ZN3RZVmNXZGwzWmVQ?= =?utf-8?B?Wk51UUI4RWo0RVZxTzlRMUxMVjJkYS8zdE45QUxsRmhBV0VUWGU2d0Y4aER6?= =?utf-8?B?R2lmQ2pBQUtubEM5RGJYeHhxYWNZUEU5SkxqK1g0Zm5tTWRXRWtMSW5GMlV3?= =?utf-8?B?dlZxMTVYN2xpUE9NQzAxQUhXTjZ3NVBKTFRTUDdMUDAzVHgrcVNjM2hRdWN4?= =?utf-8?B?NHFPdnk3N2dQOW8zemNncVJham4rTmduTDEwbmVmM21ZTXVJU0lNRmpOVlNr?= =?utf-8?B?OW1HRU40OENGT0hMejQvTXppRTRFL0dsbUF3L0xRQXMyMkVVL01qME44TE0x?= =?utf-8?B?U3V1RmlOMTZlWVp6WG5xWmRydjlzV0xMT3ROQTlWbUVnVmpMc2YxcHRpT21N?= =?utf-8?B?R0xsWngyZFBodjhSWlM0S1hzWFRmVjFEc2U4RXJzMENPbFNvMkZCUUhERjVw?= =?utf-8?B?SllxSit6YzRFSjVHWFQzMXpsOUE0b3pDVzllblBTakZYdGdGM3lHMmwzSGdN?= =?utf-8?B?Z2x6ZWxaSmZiK3pFemhadHVoV0oyaHhBS1dHK2FpWWdwQ0FqbmFhQzgxK2F0?= =?utf-8?B?a0JxaHg0Vk5TQi9kdkhscGdOZEo3N0Y0L2dmRVp6dHpqeUtiK3I2eFZTZ3Yr?= =?utf-8?B?eUFxTlFxZktyUXgySnFNVFdrektEQjlGNVo2ZnlFOUtWcG9CODFDbFdDeFRJ?= =?utf-8?B?c0ZmMk9WR0FJdXNNS1llUkZSeE96bkJaNmNaMVJ1UjIvWHRYTkt4T2tnSmFB?= =?utf-8?B?K0FuaHh4ZHlTcWpxM04xN095VWZTR016UldNcE8vSnJ5dDc1QWZCeFZEcTQz?= =?utf-8?B?aXAxVnRkZXEwZVZnWVNwdXBCQUdKazVPWmIzWWlXZktwMlZWWkVyd3pURGtq?= =?utf-8?B?WHJqb2xrempTMkJ2TnYwblY5QWYwQVdDcTVTS1kxWmZSY2VMWnU4Z1Z0Skxm?= =?utf-8?B?aStSWlI3YzVUM2J4dHpRU1RHOUo3THIxR3Z2emhQeENWam8vREF3R3BKaWkr?= =?utf-8?B?SDRxRFZFSW1VRStHemhuR0FmWGFReDk0TENjQzhNSWFiYytPTVljLzZralNK?= =?utf-8?B?V01oMUNTLzRUMS9PVjNmb2V1VFNEL1VOZ1dzVnZYTUFtemhjc00zMVBySFZQ?= =?utf-8?B?NGJOUmJhdVA5bDhGaU1RekVEQitKRzV3aHdrbVJQTGZjQ0FDREJINDBWK2la?= =?utf-8?B?SE1mLzBuOXh6WHRySDJwK2VpQytxeitwRDRXTzdDRnphbHhZaGZLRWNZbk5h?= =?utf-8?B?VFZzRWs1dEdnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR12MB7465.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0VlTEo0cmhIcFZRWm0zdkNGaFpqcGE0SkFIY3BCYWY0dk5MWWd5RVlqdWd2?= =?utf-8?B?WlZTcmtEZmdORzlzazNLbndpN1NXdHlBY3VkOUFKY3pKYUtjUGYvRkloZnpn?= =?utf-8?B?SllrZ0ZjdnJCWGZBdHk4bHFaZmNvNU5FazY2eUx3QkZGTlo4OCtFanlTMTM5?= =?utf-8?B?aU8venU5STlpTGtSNzE4bVRZc1U0cUE0U1JyeDhxQ3VwamVLU0ZKSEdVVWk4?= =?utf-8?B?YmlEWERiTzRmVUE3em5TbC8vR0lUc1pFRWNPZkYwUVIrcEU0UjBIRjZzYmxH?= =?utf-8?B?WnRGZ2NTUGxreldWMVJ6aHc1VTAvd2EvT0MrTEgwbDA3a2VQdGgwZXduN29X?= =?utf-8?B?a21qaUFqNWh1S3BEeWp6NnVGN2dKbDIyVmsrZUVMaVpIVFdMMHRlTzVFNXVw?= =?utf-8?B?TnlqY3djaWg5S1NVTzJSTG5VN2JySzFkekxSRms4T09zci9KTFB4Rml6MHVy?= =?utf-8?B?em5nczRRRFgrdWwveGNURGEyWlBCa21yb3BGSmZ0WGRiUTN1S3ZKN3lyZ3dk?= =?utf-8?B?VjRIZEgxbU5CUnZTNk0zZktSM0MzdHhEeURyMUQvVGI4N093YkwyRnh3aWt0?= =?utf-8?B?RSt0V2dza2FzdHN5c05hWEVSY0ZSQmQreTY4clFRbXZiT2o5NzhsM3BGMFRH?= =?utf-8?B?YlltOXh5akdXbS9kMlRXVjRHYndoc01MRkU4cnp4b2tHSHdMemQzdzgyRGpj?= =?utf-8?B?MExrZnVSZjg3aUlVYnA4aisza0NKNENJeGtQRTBJTEJBYnd2ajdZbzRmSGs5?= =?utf-8?B?U1c0Zi92dG1XRzZITzdQLytZTkVIek94RDVpVzVndWkyZEV5Q0VlbmF0U2Ey?= =?utf-8?B?b2hlcDkweGhoa2I0TmNHNCsyOUtxUFZ3WkJ2YW51SEh4KzZhQkhmQ05oOVh1?= =?utf-8?B?YjV0dmUvVGdNbDgzT2dTS0FRcFA3Wmo0cGFhbkxNRnFSekVvTTRKMGl6TExD?= =?utf-8?B?MGR0WlpCbnFwMkNydlI5cG91QzM1M1FVRXBpQlJDM0h6ZlVPQ1pXQVh2Wkcz?= =?utf-8?B?a2hqR0xTK1FoVUo4Tnl6clM3Z2hGdnJ2YUxmZTFBZ0QyNFhjWlFpd1RIQWJO?= =?utf-8?B?T0xrWjFrY1RFb3pPQ1FBakdRTDRzMm9WNU5qY2svVWROT3FYeFYvbXVIczVZ?= =?utf-8?B?SzVzN1hERXVWMTViWEw2bmNHb0ZERTZySFh4eHQ0OHVEZXY5MFdmVmF0Yito?= =?utf-8?B?N1JpYjJlWVZMZnJyT3lHOFhYQUMvcGY4ck1IamdOcjVvblovZ1k2VHFlaW1y?= =?utf-8?B?Q0UwWkttSVBwSjdxTW1lbVFaMVpjS2R1aFgxcFFwdFZkVGdhL2YzbUZyczNl?= =?utf-8?B?TjVvZ2tmbHJTOXFKeVQ1T0JKV3hpUE9IZkJWOVR2MkwvN1dXa1dxTzRWSGhr?= =?utf-8?B?ZSttd0s4S0JsU1RSVjQyNjM1WUJ0eCtSRFVISUJTQXB1cVdEbEJsemRUQWVX?= =?utf-8?B?UzVFM3lCZk50cWZTU2gvR2YyU0RGRXdCTkVnRlI4ZFRsb2lNbGRrTFk5cldB?= =?utf-8?B?WlV1ZER4MjVBQzZIcTVQTGxpNCsrdjdCNVhHY2hXRmZKZjFXcy94aHViZmFE?= =?utf-8?B?QlpvWTgrQWI1QlI2YnNmSzgzS3d6Z29KOE94WFhUQjZiSEtNeERWOGhadlV5?= =?utf-8?B?QWtJL3hzRC9iZWxqQm56USt2Vm9IMXU4a0FXY05XeWlIVHF3WitjNEhkdzdG?= =?utf-8?B?bUNjR2dsVm5XbWljaDlZa3lPT2t3c090ejU4WTR3RmF6dVhSakRYQ1QzSWJS?= =?utf-8?B?R0VMMUlmN3VQVTdia0F6R1BhY2h1cys0QnkvUmZIMGtRYThSeE4rZjRUM2FE?= =?utf-8?B?Q1dBOFBrd0tCQWFWOUtWU0xnTUxyeWxSRzdFMUZPYmorMC9ObnhXcDdtMStp?= =?utf-8?B?bmorcTNnZE56VTVOV0lRcGEzRnN0WExKN1l1Y1czY29oYTg2a2cvZnMxUEt1?= =?utf-8?B?cXBzVnFqZ2YyemZHQ0l4eXJVUmtTbEEvR2tRdlZKTGh6czQvQk5iclg5OUdq?= =?utf-8?B?d1V0OGg4SlU2aHhoNUdzTjJnL1BINXExclAyQ3BacFRVSi8rRDBsdVFwdFha?= =?utf-8?B?ZkU3OUpEUmsrV1pHaFR1NHVMaDRkcU1Yd1ZmVXh3V24xdVFuSERhNjdLbkxu?= =?utf-8?Q?bc0pRn33y9ILqzcuEiKVMU/h1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2548558e-35a3-42a4-4f39-08de28c55fa5 X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7465.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2025 06:15:31.2933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FF9FEFadsKS9b2iMmN2diZsJGHzaKwH/zgPvB17ooN6ZIfNm8yrJ2UV0LUmUQhblu7oFIimecIuY3VlFQaHK5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4206 On 11/20/2025 6:59 PM, David Hildenbrand (Red Hat) wrote: > On 11/20/25 13:24, Lance Yang wrote: >> >> >> On 2025/11/20 16:17, Garg, Shivank wrote: >>> >>> >>> On 11/20/2025 1:33 PM, Dev Jain wrote: >>>> >>>> On 20/11/25 12:20 pm, Shivank Garg wrote: >>> >>>> SCAN_PAGE_NOT_CLEAN is confusing - NOT_CLEAN literally means dirty, so why not SCAN_PAGE_DIRTY? >>>> Or SCAN_PAGE_DIRTY_OR_UNDER_WRITEBACK? Since folio_test_writeback() is true as a result of >>>> the folio being dirty, maybe just SCAN_PAGE_DIRTY can do. >>>> >>>> Reviewed-by: Dev Jain >>>> >>> Thanks for the review. >>> >>> I chose not to use SCAN_PAGE_DIRTY because dirty and writeback have different meanings[1]: >>> >>>       Dirty: Memory that is waiting to be written back to disk >>> Writeback: Memory that is actively being written back to disk >>> >>> [1] https://www.kernel.org/doc/Documentation/filesystems/proc.txt >>> >>> IIUC, a page under writeback is no longer dirty, so using SCAN_PAGE_DIRTY would be misleading >>> for pages in the writeback state. >>> >>> I considered SCAN_PAGE_DIRTY_OR_WRITEBACK initially but felt it was too long. >> >> Nit: If SCAN_PAGE_DIRTY_OR_WRITEBACK > > I would prefer that here. > I agree on this. If the consensus is SCAN_PAGE_DIRTY_OR_WRITEBACK, I'll use it in v3. Thanks, Shivank