From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B64FC433EF for ; Sun, 26 Jun 2022 19:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbiFZTtf (ORCPT ); Sun, 26 Jun 2022 15:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbiFZTtd (ORCPT ); Sun, 26 Jun 2022 15:49:33 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D42196 for ; Sun, 26 Jun 2022 12:49:31 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id cf14so10324923edb.8 for ; Sun, 26 Jun 2022 12:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cvc7WQjIfQALH8uF/wWzX8UFQ5EmdXg7iLe0SD89Mqo=; b=JT4ZjTHjXL+k64EtGK335t8/cXSx/wuAsDvOE7MSkpnLYT0urZJ1eaFKa5lIXEC8QW yPqCM8GfCtzkV/y5LV1cIda+oQQQbGv2doYMktzYGQ0LqFt0LUjIM1mc87yF5BUw5KWh myqB+Rp3cNocSG284jpQR/nGt6TTCsctUOU64mrAX6fuqguxM0MjUf0QmPqkeYGnp9Su ueXA1MD2cvnW63j76uv2i7/r5Cg8CxhsPUpaWBwGXBJeD6j/jubJv/Nu3yZN+70tD3dr 9ygms0KFNmomz0ulDXly4r3Ac+pzCiRylzXbueHsdA9B19kp3zeveA2nsB9ZOgLWjVGV 2Cbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cvc7WQjIfQALH8uF/wWzX8UFQ5EmdXg7iLe0SD89Mqo=; b=ITGtpA/clcvOTGYtnuEJGs77RwHGBTJYJbtk9Ejs7zKWLeDzjDjDZ9LvhvFjXlnJTY 2khUv/6751P8cV996D6lc4vKzR34JP+BCeg23bzrSH2ababWckQvPplnNuPfA8/KNEsI rPPQXP0YXa9WtAWHgTyVhrKkNwULJyRhHvsIHYaddZguzfvKMAwZXPEr5RFmQqfyqgAi p8G6T5jojqP0esYulJ81Clcn+kkuxu1s6OsN41V/tucuoI24a40WiAW6gIvgGZeWXEiq B9sJIb50ddzOl2RR8htjzBmqWz/enuxNqsdcU8IELeYnamHoVX3kIJW3k/1euQDNnuv5 sL1w== X-Gm-Message-State: AJIora9l8s3mCmtkuosQuswAXvSl+Uy7vlCA2C4V74JZ2486799o1bjA jRIEVCsfrqyBsv8QjNh4muDJ1A== X-Google-Smtp-Source: AGRyM1tfHsWw1mNVcRKGJuLFgpFYJrd57ydeHTObJwUV6/1lxv7hKQIq2WmU+XW3KJ/VREREuLC1Aw== X-Received: by 2002:a05:6402:42d5:b0:433:1727:b31c with SMTP id i21-20020a05640242d500b004331727b31cmr12335712edc.9.1656272970265; Sun, 26 Jun 2022 12:49:30 -0700 (PDT) Received: from [192.168.0.244] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a12-20020a170906670c00b006fe8c831632sm4068087ejp.73.2022.06.26.12.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 12:49:29 -0700 (PDT) Message-ID: <99e3ad4f-077a-0ca0-6842-b0c5a3439b68@linaro.org> Date: Sun, 26 Jun 2022 21:49:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] NFC: nxp-nci: check return code of i2c_master_recv() Content-Language: en-US To: Michael Walle , Charles Gorand Cc: =?UTF-8?Q?Cl=c3=a9ment_Perrochaud?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220626194243.4059870-1-michael@walle.cc> From: Krzysztof Kozlowski In-Reply-To: <20220626194243.4059870-1-michael@walle.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/06/2022 21:42, Michael Walle wrote: > Check the return code of i2c_master_recv() for actual errors and > propagate it to the caller. > > Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver") The check was there, so I don't see here bug. The only thing missing was a bit more detailed error message (without cast to %u) and propagating error code instead of EBADMSG, but these are not bugs. The commit msg should sound different and Fixes tag is not appropriate. > Signed-off-by: Michael Walle > --- > drivers/nfc/nxp-nci/i2c.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c > index 7e451c10985d..9c80d5a6d56b 100644 > --- a/drivers/nfc/nxp-nci/i2c.c > +++ b/drivers/nfc/nxp-nci/i2c.c > @@ -163,7 +163,10 @@ static int nxp_nci_i2c_nci_read(struct nxp_nci_i2c_phy *phy, > skb_put_data(*skb, (void *)&header, NCI_CTRL_HDR_SIZE); > > r = i2c_master_recv(client, skb_put(*skb, header.plen), header.plen); > - if (r != header.plen) { > + if (r < 0) { > + nfc_err(&client->dev, "I2C receive error %pe\n", ERR_PTR(r)); Print just 'r'. > + goto nci_read_exit_free_skb; > + } else if (r != header.plen) { > nfc_err(&client->dev, > "Invalid frame payload length: %u (expected %u)\n", > r, header.plen); Best regards, Krzysztof