mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	"linux@sciencehorizons.net" <linux@sciencehorizons.net>,
	"hadess@hadess.net" <hadess@hadess.net>,
	Grant Likely <glikely@secretlab.ca>,
	jikos@kernel.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: screen rotation flipped in 4.8-rc
Date: Sat, 3 Sep 2016 16:02:17 +0100	[thread overview]
Message-ID: <99e3b9fa-1dc5-44a5-b550-3754b8339d7d@kernel.org> (raw)
In-Reply-To: <1472856487.5025.84.camel@linux.intel.com>

On 02/09/16 23:48, Srinivas Pandruvada wrote:
> On Tue, 2016-08-30 at 22:42 +0000, Pandruvada, Srinivas wrote:
>> Hi All,
>>
>> I observed that using iio-sensor-proxy.service, the auto screen
>> rotation flipped on my laptop (Normal -> vertical, vertical->normal)
>> using kernel v4.8.
>>
>> Anyone else has seen this?
>>
>> I did a bisect and found a commit, which I am not sure how can it
>> impact.
>>
>>
>> commit 703b5faf22fbddf984a361e6555f3a03fdba63d9
>> Author: George Spelvin <linux@sciencehorizons.net>
>> Date:   Fri Jun 10 00:22:12 2016 -0400
>>
> [...]
> 
> It turns out to be some assumption user space program is making about
> the traversing directory using glib call g_dir_read_name(). 
> 
> With the commit 703b5faf22fbddf984a361e6555f3a03fdba63d9 (fs/dcache.c:
> Save one 32-bit multiply in dcache lookup)
>  in kernel 4.8-rc, somehow the order is changed (so the in_accel_y was
> appearing before in_accel_x )
> 
> I modified user space program to use correct iio scan element index to
> determine byte offset instead depending on the glib_dir_read_name,
> which doesn't guarantee any order.
> 
> I sent a pull request to author of iio-sensor-proxy to review.
> 
> Hadess,
> 	Please look.
> 
> https://github.com/hadess/iio-sensor-proxy/pull/99/commits/de80c50b2678
> 2ba6e899ee5a95b31b28790c940d

Good find Srinivas and thanks for keeping us updated with your progress
tracking this down!

Jonathan
> 
> 
> Thanks,
> Srinivas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2016-09-03 15:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 22:42 Pandruvada, Srinivas
2016-08-31  0:41 ` Matt Ranostay
2016-08-31 20:18   ` Pandruvada, Srinivas
2016-08-31 20:24     ` Matt Ranostay
2016-08-31 20:29       ` Pandruvada, Srinivas
2016-08-31 20:43         ` Matt Ranostay
2016-08-31 22:53           ` Srinivas Pandruvada
2016-09-01  0:48             ` Matt Ranostay
2016-09-02 22:48 ` Srinivas Pandruvada
2016-09-03 15:02   ` Jonathan Cameron [this message]
2016-09-06 12:25   ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99e3b9fa-1dc5-44a5-b550-3754b8339d7d@kernel.org \
    --to=jic23@kernel.org \
    --cc=glikely@secretlab.ca \
    --cc=hadess@hadess.net \
    --cc=jikos@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@sciencehorizons.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®