From: linmiaohe <linmiaohe@huawei.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, <wensong@linux-vs.org>,
<horms@verge.net.au>, <ja@ssi.bg>, <pablo@netfilter.org>,
<kadlec@blackhole.kfki.hu>, <fw@strlen.de>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <lvs-devel@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
<linux-kernel@vger.kernel.org>
Cc: Mingfangsen <mingfangsen@huawei.com>, <liujie165@huawei.com>
Subject: Re: [PATCH] ipvs:set sock send/receive buffer correctly
Date: Thu, 18 Apr 2019 10:17:32 +0800 [thread overview]
Message-ID: <99e42cf0-bb45-cc88-a6f6-aff1098745dd@huawei.com> (raw)
In-Reply-To: <a8ed41f3-1576-cbf6-907a-f501b3df189e@gmail.com>
On 2019/4/18 10:02, Eric Dumazet wrote:
>
>
> On 04/17/2019 06:45 PM, linmiaohe wrote:
>>
>
>> In fact, I just implemented this function with reference to
>> sock_setsockopt(). When val * 2 overflow, we will set the
>> buffer as SOCK_MIN_SNDBUF, just as sock_setsockopt() do.
>>
>
> I do not think so.
>
> Please check latest linux kernel, not some old version.
>
> commit 4057765f2dee79cb92f9067909477303360be8d3 sock: consistent handling of extreme SO_SNDBUF/SO_RCVBUF values
>
> .
>
Thank you for your patience, you are right. My version is not the newest.
I will update my patch according to the newest version. Thanks again.
prev parent reply other threads:[~2019-04-18 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:18 linmiaohe
2019-04-17 13:18 ` Eric Dumazet
2019-04-18 1:45 ` linmiaohe
2019-04-18 2:02 ` Eric Dumazet
2019-04-18 2:17 ` linmiaohe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e42cf0-bb45-cc88-a6f6-aff1098745dd@huawei.com \
--to=linmiaohe@huawei.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=liujie165@huawei.com \
--cc=lvs-devel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®