From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87B6C77B7F for ; Fri, 19 May 2023 10:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbjESKvL convert rfc822-to-8bit (ORCPT ); Fri, 19 May 2023 06:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbjESKvI (ORCPT ); Fri, 19 May 2023 06:51:08 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21BF9192 for ; Fri, 19 May 2023 03:51:05 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 6934D7FFB; Fri, 19 May 2023 18:51:02 +0800 (CST) Received: from EXMBX067.cuchost.com (172.16.6.67) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 19 May 2023 18:51:02 +0800 Received: from EXMBX066.cuchost.com (172.16.7.66) by EXMBX067.cuchost.com (172.16.6.67) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 19 May 2023 18:51:02 +0800 Received: from EXMBX066.cuchost.com ([fe80::5947:9245:907e:339f]) by EXMBX066.cuchost.com ([fe80::5947:9245:907e:339f%17]) with mapi id 15.00.1497.044; Fri, 19 May 2023 18:51:02 +0800 From: JeeHeng Sia To: Song Shuai , "paul.walmsley@sifive.com" , "palmer@dabbelt.com" , "aou@eecs.berkeley.edu" , Mason Huo , "conor.dooley@microchip.com" CC: "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] riscv: hibernation: Replace jalr with jr before suspend_restore_regs Thread-Topic: [PATCH] riscv: hibernation: Replace jalr with jr before suspend_restore_regs Thread-Index: AQHZihi0VP3rwfUufEaZ9/XX0w5YHK9hZs+g Date: Fri, 19 May 2023 10:51:01 +0000 Message-ID: <99eac7b418bd4b518e2edb7379e1158f@EXMBX066.cuchost.com> References: <20230519060854.214138-1-suagrfillet@gmail.com> In-Reply-To: <20230519060854.214138-1-suagrfillet@gmail.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [60.53.70.89] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org looks good to me. Thanks Regards Jee Heng > -----Original Message----- > From: Song Shuai > Sent: Friday, May 19, 2023 2:09 PM > To: paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; JeeHeng Sia ; Mason > Huo ; conor.dooley@microchip.com > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Song Shuai > Subject: [PATCH] riscv: hibernation: Replace jalr with jr before suspend_restore_regs > > No need to link the x1/ra reg via jalr before suspend_restore_regs > So it's better to replace jalr with jr. > > Signed-off-by: Song Shuai > --- > arch/riscv/kernel/hibernate-asm.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kernel/hibernate-asm.S b/arch/riscv/kernel/hibernate-asm.S > index effaf5ca5da0..5c76671c7e15 100644 > --- a/arch/riscv/kernel/hibernate-asm.S > +++ b/arch/riscv/kernel/hibernate-asm.S > @@ -50,7 +50,7 @@ ENTRY(hibernate_restore_image) > REG_L s4, restore_pblist > REG_L a1, relocated_restore_code > > - jalr a1 > + jr a1 > END(hibernate_restore_image) > > /* > @@ -73,5 +73,5 @@ ENTRY(hibernate_core_restore_code) > REG_L s4, HIBERN_PBE_NEXT(s4) > bnez s4, .Lcopy > > - jalr s2 > + jr s2 I am content with these changes, as they do not involve a return after the jump > END(hibernate_core_restore_code) > -- > 2.20.1