From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C63733F384 for ; Fri, 10 Apr 2026 10:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775815820; cv=none; b=Ptk3rn/2QncHF/kn+CZ/tXz/xu+2hYq8/EnztzWMfKPDe+5tRZeRYVPtUEkoVA6DFXPZJa9CuDhhRbPqxciOBiy2qYPSLDyafu+XSYdL8rVK0oI8kwtlYBKp61/agfufVhaQIdWB1BIo628XEQeagwjwW9BQcMGMDutXWNdSbYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775815820; c=relaxed/simple; bh=2OV7x9Lv/OakKlu335yqsl8m0c90dxHBGy/Fy/fnXyg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E8jL6+IobRniS0BWSJ3qIY8pBfOPkXQtJ6WimM24Go2GseJldd74zrGy1D4d35cp5KVeoAHSQ/A9gaWwSnclybVRPfBKAX4G0UQleYkE7FYw5zAsKBoH6VWIYB195vWiE27PG6fq97HifBO0A6dj/amevVcckq5VIsasxnS1JSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ix+X0e4r; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LS6TnZd6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ix+X0e4r"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LS6TnZd6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A53VDS779511 for ; Fri, 10 Apr 2026 10:10:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 50pbHWz5L4Ep8xCFcd58OKxaduUzmduABDRD2HJ+f0E=; b=Ix+X0e4rkdPbgHYr zpWv3zUVcA28HCEeq6DsnoGa99IPyAyr1y9FuDaC7MzX5uIgSgEDf3GrQHCo5pTa DDIo5JycuxVzgp1CcnNjCCd33iJ4WVetTFEtHpGy7KPXf5xf47s1VB5JSipftHrD 4ZKiv12DPbx5JybQuGr9m4QEB/RU4WNNarcatZHaWcBmc7DTWbd9Ul/aGlSEhn2e LpHWHm3yusK2+0FE+IB+zsOQQ3i7HYfWUr2d6Py0oTySF8dC8/Qi5OfKzrl2X+YD 8Zf5VaiVmTnTO0q1azpwp0vybK4X/0mG4hNxRrmsCk+v8a+iB7+YtpiMUTBvjC7G nPLz9g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dec8hv260-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 10:10:17 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35d98c6ab60so2009587a91.1 for ; Fri, 10 Apr 2026 03:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775815816; x=1776420616; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=50pbHWz5L4Ep8xCFcd58OKxaduUzmduABDRD2HJ+f0E=; b=LS6TnZd6Qtb35KRNh8i8F/LVpRA8EIAqOlwZTEYZW0uDJ/shDJI2777MQHsQWLJO5S c6D1EDff999hQL1xKjAmBf3fYAigHOu/CL/UxZKZfmYIeit1u8pUMGGRBaQJO82vIGbN 2ItfcFhJXHRcy0wkCWm10wuNoxrGp8YC2Pdd7IC/LhrrHBuafzlYNWeWOPLulOygfLh1 T7y9ksOud/THbMPUZuMWnquVSkN+R6NF41/TbCO+tRFsOJb7Z8XLRxeD5yutaQuyOhBm vzKN0HyzdatwNTIBsxdpd00SYM1gsljWnae/pa0Q1C65ZMdOIx/3GENBrNNgHBoWEXme BKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815816; x=1776420616; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=50pbHWz5L4Ep8xCFcd58OKxaduUzmduABDRD2HJ+f0E=; b=V9KrbgRSwIg5sZq3TqeLVvidp5Nct8twcxjYAaC8BUiVlG36ak5uFCMINw0rS7KFPU EH67rxWXCmFzjRcE/9jTSGbR1WqgFO/73xZJNKIE4vI+dlQIepREfCb1r+EBMmGkhrtI 23IJ3HPdiAJHqd3WotpWIRegF6QMlQQw5l8K+U1wVtVgy6MrBzJgBguMEp6E3tNWUCun iz+DWB4YURLbYieYSTvDBghGcs0XnkKmU7URwqFZKNNtFSQ3viWmjhILtinFhikLVfAM f8IynfcOpb/ePsbkAVYJtKlDqEaYO+DpfS7x0oRH0Rij8hbkaeMLLmAZhsJwfTPJV7JD ZBYw== X-Forwarded-Encrypted: i=1; AJvYcCW+Vvh9bnunbs82+cU4Wzp547IBgvPb1ae7CgI+YTyu1/wB+FFoe5znBrst1DUdLBZyxUjEB3xpPeZrIN4=@vger.kernel.org X-Gm-Message-State: AOJu0YzVylSfM44LM803pyUdvLR/m4kJH3MS+vfjDbXTDxqYOYwwz1dp +ef7Ml1sTkVzv6HuZnR4XvuJGEcva7ldXbkKzwHyTsHkYsFTipfIapL+rEc5GcQ5OZ+FoVVFhk5 z4Vx8iJLIfoXbqfcuPeW+ALBXa+V8QYQYx2pFhNfTUSV049zZEAELTz2N8nb8aRSGGns= X-Gm-Gg: AeBDiev8vsrxmDo1uNzEM6lo3bYdMXRYYfU5kwt4A57Paj7nkALWIhVVa2cwSomuvfE jn5rZIAxTtIPNjcLQiY6xax6+50tdxHFwfm1pKkOkKWOQuJpCIrIeLGwu8Pg58LhvsEJk8Nm0RE QfRGTxR2CneaMCXAI+cRwKjGkFSKsVf0PyKiCesfG1E8uZMB+UgqDH9PCiNyThTYfvgKx3sPJRo 7ku513/YQagyF5pBuH+NVGVlzcldqK6IFKIjx3fRR52JzLXVJt+B+jC5r18oJvbHuE8j7dpx8GL tJHKk3dXse0yJDa6wcQuFhgHaDMuFba9sQIE/4BIvBll/wROAU5d+O7I21OGEORbwVWSYpBW4LG ZXrxmXgCrorGK8eSEkXk3llM9vSJb44RE1T1XXoRYpGCIcrWsAOSj9ik= X-Received: by 2002:a17:90b:4ac2:b0:35d:a559:5c0a with SMTP id 98e67ed59e1d1-35e43022d4cmr2068887a91.6.1775815815740; Fri, 10 Apr 2026 03:10:15 -0700 (PDT) X-Received: by 2002:a17:90b:4ac2:b0:35d:a559:5c0a with SMTP id 98e67ed59e1d1-35e43022d4cmr2068850a91.6.1775815815046; Fri, 10 Apr 2026 03:10:15 -0700 (PDT) Received: from [192.168.202.18] ([106.192.36.31]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e34fd383dsm8291028a91.6.2026.04.10.03.10.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 03:10:14 -0700 (PDT) Message-ID: <99eb55a8-6370-bf7b-f9de-e88231454b0e@oss.qualcomm.com> Date: Fri, 10 Apr 2026 15:40:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC 4/7] media: qcom: iris: vdec: update size and stride calculations for 10bit formats Content-Language: en-US To: Neil Armstrong , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org> <20260408-topic-sm8x50-iris-10bit-decoding-v1-4-428c1ec2e3f3@linaro.org> From: Vishnu Reddy In-Reply-To: <20260408-topic-sm8x50-iris-10bit-decoding-v1-4-428c1ec2e3f3@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PMM/P/qC c=1 sm=1 tr=0 ts=69d8cc89 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=NP+XTJQPoO73HiJDCNFURg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=ry5-__lr15mXsCcL3A4A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: qDGavtcnboloAWRkjCpPZd77BHlMGUZV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA5NCBTYWx0ZWRfX3MVzqR+Xjtph tPd3gN18kZ2HQJUV5S1AmYtq5lrJnQR6+sXV69f716aj/AAo8bfqDrPw9IZhQfF9K0/D/qNfxi4 2ury4ApCN4Gca9fqoAaBRzXLYiCUB+1kFUg9QpSy8vlghdpK25XHmTkQzZ8dzVU8xwID5MlSv3q V/Vk38ogf80WHV5bLffZIobWPkc4UTPjUu9UQb5MFH9OeG4r0BXkbTY7Bxcv2Qi7oicRF7r1OYt FfyXRg9vIdkbZnFDaT2qydHvr82Yz0f2cXOJsKP1deq3KzziZZ8xNjcLe5ItNXYs1hENOOyyGc7 r89UhuKzc6ruKFy3iq4QwCTXFp9LhejlIr0Uz6axMERt7nn4Bv1CQZr4Oc7xc8HwqsKUaiBNsP4 W4tUKbaf0Rfv9BBp7bI/7q2JEH00HCySFy6i/VT9jGxGhSZdFbpS/FNRsuam34wQhq6c+gq1pwO 6iORKmEjn/boZrhqS5w== X-Proofpoint-GUID: qDGavtcnboloAWRkjCpPZd77BHlMGUZV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100094 On 4/8/2026 10:13 PM, Neil Armstrong wrote: > Update the gen2 response and vdec s_fmt code to take in account > the P010 and QC010 when calculating the width, height and stride. > > Signed-off-by: Neil Armstrong > --- > .../platform/qcom/iris/iris_hfi_gen2_response.c | 19 ++++++++++++++++--- > drivers/media/platform/qcom/iris/iris_vdec.c | 21 ++++++++++++++++++--- > 2 files changed, 34 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c > index 8e19f61bbbf9..d268149191ea 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c > @@ -542,9 +542,22 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst) > pixmp_ip->width = width; > pixmp_ip->height = height; > > - pixmp_op->width = ALIGN(width, 128); > - pixmp_op->height = ALIGN(height, 32); > - pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); > + pixmp_op->width = pixmp_op->pixelformat == V4L2_PIX_FMT_QC10C ? > + ALIGN(width, 192) : ALIGN(width, 128); > + pixmp_op->height = pixmp_op->pixelformat == V4L2_PIX_FMT_QC10C ? > + ALIGN(height, 16) : ALIGN(height, 32); > + switch (pixmp_op->pixelformat) { > + case V4L2_PIX_FMT_P010: > + pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256); > + break; > + case V4L2_PIX_FMT_QC10C: > + pixmp_op->plane_fmt[0].bytesperline = ALIGN(ALIGN(width, 192) * 4 / 3, 256); > + break; > + case V4L2_PIX_FMT_NV12: > + case V4L2_PIX_FMT_QC08C: > + pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); > + break; > + } > pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); > > matrix_coeff = subsc_params.color_info & 0xFF; > diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c > index 719217399a30..ca0518c27834 100644 > --- a/drivers/media/platform/qcom/iris/iris_vdec.c > +++ b/drivers/media/platform/qcom/iris/iris_vdec.c > @@ -272,10 +272,25 @@ int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f) > fmt = inst->fmt_dst; > fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; > fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat; > - fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); > - fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); > + codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 192 : 128; > + fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, codec_align); > + codec_align = f->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C ? 16 : 32; > + fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, codec_align); > fmt->fmt.pix_mp.num_planes = 1; > - fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f->fmt.pix_mp.width, 128); > + switch (f->fmt.pix_mp.pixelformat) { > + case V4L2_PIX_FMT_P010: > + fmt->fmt.pix_mp.plane_fmt[0].bytesperline = > + ALIGN(f->fmt.pix_mp.width * 2, 256); > + break; > + case V4L2_PIX_FMT_QC10C: > + fmt->fmt.pix_mp.plane_fmt[0].bytesperline = > + ALIGN(f->fmt.pix_mp.width * 4 / 3, 256); > + break; > + case V4L2_PIX_FMT_NV12: > + case V4L2_PIX_FMT_QC08C: > + fmt->fmt.pix_mp.plane_fmt[0].bytesperline = f->fmt.pix_mp.width; In the removed code, bytesperline for NV12 and QC08C was aligned to 128 bytes. In the new code, Is that alignment missed or not required? > + break; > + } > fmt->fmt.pix_mp.plane_fmt[0].sizeimage = iris_get_buffer_size(inst, BUF_OUTPUT); > inst->buffers[BUF_OUTPUT].min_count = iris_vpu_buf_count(inst, BUF_OUTPUT); > inst->buffers[BUF_OUTPUT].size = fmt->fmt.pix_mp.plane_fmt[0].sizeimage; >