From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, tali.perry1@gmail.com,
joel@jms.id.au, venture@google.com, yuenn@google.com,
benjaminfair@google.com
Cc: openbmc@lists.ozlabs.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v22 3/8] arm: dts: nuvoton: npcm7xx: modify rst syscon node
Date: Wed, 10 Jan 2024 22:01:00 +0100 [thread overview]
Message-ID: <99eca166-7d78-4ada-ac0a-ad67f3d8eb33@linaro.org> (raw)
In-Reply-To: <20240108135421.684263-4-tmaimon77@gmail.com>
On 08/01/2024 14:54, Tomer Maimon wrote:
> rst node name and compatible property modified since clock and reset are
> handled in the same memory region.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index 868454ae6bde..f72c5a03d04c 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -93,8 +93,8 @@ gcr: gcr@800000 {
> reg = <0x800000 0x1000>;
> };
>
> - rst: rst@801000 {
> - compatible = "nuvoton,npcm750-rst", "syscon", "simple-mfd";
> + clk_rst: syscon@801000 {
> + compatible = "nuvoton,npcm750-clk-rst", "syscon", "simple-mfd";
NAK. This breakes the users, is not justified, is not explained.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-10 21:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 13:54 [PATCH v22 0/8] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 1/8] dt-bindings: clock: npcm845: Add reference 25m clock property Tomer Maimon
2024-01-08 21:09 ` Rob Herring
2024-01-09 6:45 ` Tomer Maimon
2024-01-09 17:08 ` Rob Herring
2024-01-10 13:47 ` Tomer Maimon
2024-01-10 20:54 ` Krzysztof Kozlowski
2024-01-10 21:45 ` Stephen Boyd
2024-01-16 15:21 ` Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 2/8] arm64: dts: nuvoton: npcm8xx: add refernace clock Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 3/8] arm: dts: nuvoton: npcm7xx: modify rst syscon node Tomer Maimon
2024-01-10 21:01 ` Krzysztof Kozlowski [this message]
2024-01-16 19:51 ` Tomer Maimon
2024-01-16 20:33 ` Krzysztof Kozlowski
2024-01-08 13:54 ` [PATCH v22 4/8] dt-bindings: soc: nuvoton: add binding for clock and reset registers Tomer Maimon
2024-01-10 20:59 ` Krzysztof Kozlowski
2024-01-16 19:02 ` Tomer Maimon
2024-01-16 20:37 ` Krzysztof Kozlowski
2024-01-22 17:14 ` Tomer Maimon
2024-01-24 14:21 ` Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 5/8] arm64: dts: nuvoton: npcm8xx: add clock reset syscon node Tomer Maimon
2024-01-10 21:01 ` Krzysztof Kozlowski
2024-01-16 19:03 ` Tomer Maimon
2024-01-08 13:54 ` [PATCH v22 6/8] dt-bindings: clock: npcm845: replace reg with syscon property Tomer Maimon
2024-01-10 20:59 ` Krzysztof Kozlowski
2024-01-16 19:37 ` Tomer Maimon
2024-01-16 20:40 ` Krzysztof Kozlowski
2024-01-22 17:26 ` Tomer Maimon
2024-01-23 7:44 ` Krzysztof Kozlowski
2024-01-08 13:54 ` [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: " Tomer Maimon
2024-01-10 20:59 ` Krzysztof Kozlowski
2024-01-16 19:39 ` Tomer Maimon
2024-01-16 20:41 ` Krzysztof Kozlowski
2024-01-08 13:54 ` [PATCH v22 8/8] clk: npcm8xx: add clock controller Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99eca166-7d78-4ada-ac0a-ad67f3d8eb33@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®