mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>, Ingo Molnar <mingo@redhat.com>,
	Howard McLauchlan <hmclauchlan@fb.com>,
	Josef Bacik <jbacik@fb.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH v4] tracing: remove igrab() iput() call from uprobes.c
Date: Fri, 20 Apr 2018 18:36:38 +0000	[thread overview]
Message-ID: <9BEE77C2-B1BE-4697-919B-06997F05A0B0@fb.com> (raw)
In-Reply-To: <20180420142922.08ad9e64@gandalf.local.home>



> On Apr 20, 2018, at 11:29 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> On Fri, 20 Apr 2018 11:08:47 -0700
> Song Liu <songliubraving@fb.com> wrote:
> 
>> For uprobes.c sisde, igrab() is not necessary. So we removed it and
> 
> You don't need to send another patch, but what is the above sentence
> suppose to say?
> 
> -- Steve
> 

Sorry for the typo. I meant "For uprobes.c side". Or "it is not necessary
to call igrab() in uprobe_register(), as the caller is required to keep
the inode reference. 

Song


>> added comments on requirements to callers of uprobe_register().

  reply	other threads:[~2018-04-20 18:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 18:08 Song Liu
2018-04-20 18:29 ` Steven Rostedt
2018-04-20 18:36   ` Song Liu [this message]
2018-04-20 18:40     ` Steven Rostedt
2018-04-20 18:49       ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BEE77C2-B1BE-4697-919B-06997F05A0B0@fb.com \
    --to=songliubraving@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=hmclauchlan@fb.com \
    --cc=jbacik@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®