From: Kees Cook <kees@kernel.org>
To: Bill Wendling <morbo@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3] seq_buf: add seq_buf_strlen(), seq_buf_init_append(), seq_buf_puts_trunc()
Date: Thu, 17 Sep 2026 07:24:31 -0700 [thread overview]
Message-ID: <9DA6BE5B-E65F-4E8B-8B56-A861042100E4@kernel.org> (raw)
In-Reply-To: <20260917011359.1585961-1-morbo@google.com>
On September 16, 2026 6:13:59 PM PDT, Bill Wendling <morbo@google.com> wrote:
>Converting some strlcat() call sites seq_buf need behavior seq_buf
>doesn't currently provide, either directly or without introducing subtle
>bugs:
Ah, our implementations have crossed paths in flight. :)
> - seq_buf_strlen(): seq_buf_used() reports the full buffer size when
We agree, we need this one. :)
> - seq_buf_init_append(): seq_buf_init() always clears the buffer it's
Oh, nice, yeah this is cool. I'd like a different name that mentions "str"? Maybe _from_str?
> - seq_buf_puts_trunc(): seq_buf_puts() (like seq_buf_printf() and
I prefer my solution that just truncates and sets overflow. Nothing i found needed the non-trunc behavior.
I'll send a v2 of the other series with seq_buf_init_from_str?
-Kees
--
Kees Cook
prev parent reply other threads:[~2026-09-17 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 22:15 [PATCH] " Bill Wendling
2026-09-16 22:21 ` [PATCH v2] " Bill Wendling
2026-09-16 23:47 ` Andrew Morton
2026-09-16 23:55 ` Bill Wendling
2026-09-17 1:13 ` [PATCH v3] " Bill Wendling
2026-09-17 14:24 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DA6BE5B-E65F-4E8B-8B56-A861042100E4@kernel.org \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®