From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B04212DC792 for ; Fri, 14 Nov 2025 18:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763145568; cv=none; b=sh7y7GFNxOoMIjNyDO6ViYuA3WEf2ESmP9o1Zelur5KmrmRLig1mQOv6XI4tTub2HSjU4RhGOltQ/4vm3xU/R5kUWqET5U0B4qDTQ3ZzwD4QxMpRpQMv5hzqq2dUxI8q8zF4F+qwFpFB0/tAf3q1iT4FsX7ySexAwXTjzP8DOKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763145568; c=relaxed/simple; bh=sCM5CZHDJgyl2q1jrA6chqTv1b4sZr5EAHWs+3qHbg0=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=GcUK95FW47HUkxOlLiNFSZmv5JVxkb/qKh3ew7p1Y3Lc/aofiyLO6xLWSz8epu3wehAWSuTFCjB5tE4xqZj+qbgl2a7NYVMr3g8eTzzMmKY+DGJpWQmHnsnuKRtE3jFRJaEqIvYl5AvftFzInvKhfD7njm/uiR9HhoyH94n+pWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LLOvsTha; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LLOvsTha" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-29808a9a96aso22572545ad.1 for ; Fri, 14 Nov 2025 10:39:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763145562; x=1763750362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=NlxMrLXPrBCU+jO2UaTPbpl/IwecL0/VlFyK5yk0EgQ=; b=LLOvsThajzHRXzrnTogleokRg7gdT8jpYbQp212oKGuBDcADyTNTD6P5ZbKjjPPVEv vKz9nI3ikWgR9IPKq3IimV8hWyKMVGwniLgypWQ1eyhiKDWUIA0rUkC+15B8VmCA+TYF J07GHbVsvr4QztgZMGLAb+EpUGMY/NFXfnk5rVHuquwvwlLihAZthZJePvchZXTja8Zs RNFn1vCZkdXts3xtG3Q633AS6jIGv/fozGjiB+f1A+SbM0nQU5ebKDArPBL72pmyUpqX Hw2HHbbFuGg/haU1wN4FCKBYMSO+nu2+LbLopVshkfF/WKomRSDSlxzT8M4DhjML4Vgr nopg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763145562; x=1763750362; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NlxMrLXPrBCU+jO2UaTPbpl/IwecL0/VlFyK5yk0EgQ=; b=J3U5Bm3ORHHzSTguzniQ81x3QuS+lJs2tWH6jzcwB54VUAIkIfA7zPgqA1knNHmJLQ PT2ElyevvizAfleekS4aVP7c0PqjnYPYvrViS0cqN7oIDV+X3VGu/bj93k1mS8OW4VdK 6jQu2L7jn5SnqhQaVeDl4ZmXIiwRgmaqzRcKofG4IspBmVfQvwkTIxFybt+mynBcfj7c WXGZlGf8+CaVi3mWNUVzoSRVuw/dv4Y512QyWEUFZ/ziTTIm8iiPF4dTXU9hCF9U5737 +0WatGK+aNX1cx3/0qy2OEz8s4Zj5tCPVubZIc1GblEgC0c1CL8xUPehvfD4hOIbt8jT g5MA== X-Forwarded-Encrypted: i=1; AJvYcCVWcUm4cU5bB2+g859tOBIOlJwOsIkpVKn9sRkJun4nwX2+gu4Zpv7ccl9+s42fYvreCeg1n0MboSpi98c=@vger.kernel.org X-Gm-Message-State: AOJu0YwvZKlDUExFRoz1tLIB2jUPde2+Fjq9Yq2+exWur+3BopA4UJCi XcfSNv0z2kqHuXxDcB3Xrl2LiQW9O1brmacaIQZKCMJZpjkN9HkCY4To X-Gm-Gg: ASbGncscnevkZGaH763GtU6gVEPxaOC+Goej6Bh7ZQCfbCyE1PxUyC4I7KhqhK2+zxx wI2o9yMr9NMrkEidLURaCiGnwboBXd921D9Ikt/H1ltMxqOvNSO+q5mwscbKcTBvgTbYVrKeXbh 4uOhDmHBkBx/1zfhRZ/0KrtzHxZfWiizniMjYFpiYvqG3KnhHif197oTRk2Y1Iom2snyINzzRe6 h1RDQ5CbUNDsSkfVdrwfyDz2nAFbAMVaLW7GtClIil8/wt7Xt8FQoHfrXLbNJaknLriBCBv9fVf L7nCMC32ccK5Hl+3xt4e0fGnhGwOXM7pDeXlph8widz5Ld+TJOGTP9cFSahWKyznz6LjpX1J1SW bfCCZ7X2UQ/K2RDuCwupmUZI+1/MrDaZ10wV5IChOxIJ+4wzJgNsunDsIOa8MF5fkjJu8kSDidY X5bodYKViri+gTk/R0mhIFa4733fJbgw+crqk0xsAfj1eO5ec8ZcveAVv1ffgvsTOzdNGonjsmg bz7aDHQRQ== X-Google-Smtp-Source: AGHT+IF1cAptumORDftaftQhtRmfE70v3gTNtStBR9Wa3ZnIqnTjvq3Q6xjWxNHyknDfcBM12ABbKA== X-Received: by 2002:a05:7022:7e06:b0:11a:2e9c:1119 with SMTP id a92af1059eb24-11b410f599cmr970592c88.19.1763145561798; Fri, 14 Nov 2025 10:39:21 -0800 (PST) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b06088604sm13030798c88.7.2025.11.14.10.39.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 10:39:21 -0800 (PST) Date: Fri, 14 Nov 2025 10:39:19 -0800 From: "Derek J. Clark" To: Rong Zhang , Mark Pearson , Armin Wolf , Hans de Goede , =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= CC: Guenter Roeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v5_0/7=5D_platform/x86=3A_lenovo-wm?= =?US-ASCII?Q?i-=7Bcapdata=2Cother=7D=3A_Add_HWMON_for_fan_speed?= User-Agent: Thunderbird for Android In-Reply-To: <20251114175927.52533-1-i@rong.moe> References: <20251114175927.52533-1-i@rong.moe> Message-ID: <9E2AB845-08A5-4579-9055-1C8B10244247@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On November 14, 2025 9:59:12 AM PST, Rong Zhang wrote: >Lenovo WMI Other Mode interface also supports querying or setting fan >speed RPM=2E This capability is decribed by LENOVO_CAPABILITY_DATA_00=2E >Besides, LENOVO_FAN_TEST_DATA provides reference data for self-test of >cooling fans, including minimum and maximum fan speed RPM=2E > >This patchset turns lenovo-wmi-capdata01 into a unified driver (now >named lenovo-wmi-capdata) for LENOVO_CAPABILITY_DATA_{00,01} and >LENOVO_FAN_TEST_DATA; then adds HWMON support for lenovo-wmi-other: > > - fanX_enable: enable/disable the fan (tunable) > - fanX_input: current RPM > - fanX_max: maximum RPM > - fanX_min: minimum RPM > - fanX_target: target RPM (tunable) > >LENOVO_CAPABILITY_DATA_{00,01} presents on all devices, so >both binds to lenovo-wmi-other=2E However, some device does not have >LENOVO_FAN_TEST_DATA and its presence is described by >LENOVO_CAPABILITY_DATA_00; hence, the former binds to the latter and a >callback is used to pass the data to lenovo-wmi-other=2E > >The implementation does not rely on a specific binding sequence=2E This >has been fuzz-tested using: > > #!/bin/bash > > DRV_DIR=3D/sys/bus/wmi/drivers/lenovo_wmi_cd > CAPDATA_GUIDS=3D( > $(find "$DRV_DIR"/ -name '*-*-*-*-*-*' -printf "%f ") > ) > > b() { sudo tee "$DRV_DIR"/bind <<<"$1"; } > u() { sudo tee "$DRV_DIR"/unbind <<<"$1"; } > > for guid in "${CAPDATA_GUIDS[@]}"; do > u "$guid" > done > > while read -rsa perm; do > for guid in "${perm[@]}"; do > b "$guid" > done > sensors | grep -A3 lenovo_wmi_other || true > for guid in "${perm[@]}"; do > u "$guid" > done > done < <(python3 -c " > from itertools import permutations > ps =3D permutations('${CAPDATA_GUIDS[*]}'=2Esplit()) > for p in ps: print(' '=2Ejoin(p))") > > for guid in "${CAPDATA_GUIDS[@]}"; do > b "$guid" > done > >Tested on ThinkBook 14 G7+ ASP=2E > >Changes in v5: >- Do not cast pointer to non-pointer or vice versa (thanks kernel test > robot) >- Fix missing include (ditto) >- Link to v4: https://lore=2Ekernel=2Eorg/r/20251113191152=2E96076-1-i@ro= ng=2Emoe/ > >Changes in v4: >- Get rid of wmi_has_guid() (thanks Armin Wolf's inspiration) > - Add [PATCH v4 6/7], please review & test > - Rework HWMON registration > - Collect fan into from capdata00 and capdata_fan separately > - Use a callback to collect fan info from capdata_fan > - Trigger HWMON registration only if all fan info is collected > - Do not check 0x04050000=2Esupported, implied by the presense of > capdata_fan >- Drop Reviewed-by & Tested-by from [PATCH v4 7/7] due to the changes, > please review & test >- Link to v3: https://lore=2Ekernel=2Eorg/r/20251031155349=2E24693-1-i@ro= ng=2Emoe/ > >Changes in v3: >- Fix grammar (thanks Derek J=2E Clark) >- Link to v2: https://lore=2Ekernel=2Eorg/r/20251030193955=2E107148-1-i@r= ong=2Emoe/ > >Changes in v2: >- Add a workaround for ACPI methods that return a 4B buffer for u32 > (thanks Armin Wolf) >- Fix function documentation (thanks kernel test bot) >- Reword documentation (thanks Derek J=2E Clark) >- Squash min/max reporting patch into the initial HWMON one (ditto) >- Query 0x04050000 for interface availability (ditto) > - New parameter "expose_all_fans" to skip this check >- Enforce min/max RPM constraint on set (ditto) > - New parameter "relax_fan_constraint" to disable this behavior > - Drop parameter "ignore_fan_cap", superseded by the next one > - New parameter "expose_all_fans" to expose fans w/o such data >- Assume auto mode on probe (ditto) >- Do not register HWMON device if no fan can be exposed >- fanX_target: Return -EBUSY instead of raw target value when fan stops >- Link to v1: https://lore=2Ekernel=2Eorg/r/20251019210450=2E88830-1-i@ro= ng=2Emoe/ > >Rong Zhang (7): > platform/x86: lenovo-wmi-helpers: Convert returned buffer into u32 > platform/x86: Rename lenovo-wmi-capdata01 to lenovo-wmi-capdata > platform/x86: lenovo-wmi-{capdata,other}: Support multiple Capability > Data > platform/x86: lenovo-wmi-capdata: Add support for Capability Data 00 > platform/x86: lenovo-wmi-capdata: Add support for Fan Test Data > platform/x86: lenovo-wmi-capdata: Wire up Fan Test Data > platform/x86: lenovo-wmi-other: Add HWMON for fan reporting/tuning > > =2E=2E=2E/wmi/devices/lenovo-wmi-other=2Erst | 43 +- > drivers/platform/x86/lenovo/Kconfig | 5 +- > drivers/platform/x86/lenovo/Makefile | 2 +- > drivers/platform/x86/lenovo/wmi-capdata=2Ec | 808 ++++++++++++++++++ > drivers/platform/x86/lenovo/wmi-capdata=2Eh | 65 ++ > drivers/platform/x86/lenovo/wmi-capdata01=2Ec | 302 ------- > drivers/platform/x86/lenovo/wmi-capdata01=2Eh | 25 - > drivers/platform/x86/lenovo/wmi-helpers=2Ec | 22 +- > drivers/platform/x86/lenovo/wmi-other=2Ec | 511 ++++++++++- > 9 files changed, 1426 insertions(+), 357 deletions(-) > create mode 100644 drivers/platform/x86/lenovo/wmi-capdata=2Ec > create mode 100644 drivers/platform/x86/lenovo/wmi-capdata=2Eh > delete mode 100644 drivers/platform/x86/lenovo/wmi-capdata01=2Ec > delete mode 100644 drivers/platform/x86/lenovo/wmi-capdata01=2Eh > > >base-commit: 6da43bbeb6918164f7287269881a5f861ae09d7e Rong, I'm out of town for the weekend, but I'll bring a Lenovo device with me=2E= If I get some time I'll test the changes while I'm gone, otherwise it will= need to wait until Monday=2E Thanks, Derek