From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67B43E9F71 for ; Tue, 14 Apr 2026 15:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776180314; cv=none; b=SRWJjNpa47aVGfT6/Mpj4QPj6rIYzUGxQu56jVBF4iSOenGavajlwzzookk4SYSM+mf5TnM3ogMdUTX+0vR6SqzBP6AvKYnCZ2E2YrGvO8I7GEjF8oJ7rVyR3zxWXEFDtdAuZYsu4XptO02cKo4LL4Dj4X5IPZb8p3V1pa8DIuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776180314; c=relaxed/simple; bh=IiXYQQExsUnj2sC9snKxGX3zEcL82UZD+aOztfBb12w=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=VcTZ+eV00ku5S+2GFdno6xbgfwVFHOsvZpDOn+MxARDB8gEW/ycUjVVOrwRuBwi0YjtY8Rd80oJTDKozX4vb6UPwP/izvF8YSx+pR10cAMqbIrhXj/X7KkRUqXIwc1RRMhRRmulI0RTljh2itI6mVSL0QKUGxxf6sOnJ2rl5tJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A/ZI6UmL; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A/ZI6UmL" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-358d80f60ccso3755500a91.3 for ; Tue, 14 Apr 2026 08:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776180311; x=1776785111; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=zrnw2LUyNaW2ANHpqLyYF8hEjA5tKqE1HoISMvx1f9M=; b=A/ZI6UmLHbKdbf9Hgwt8Ov60tLsHNeuat+F0FwThnXxsRGEu1P7iEEfdpLh+mEFUN+ viASkFBTQXSNiYbEo7kMZKB21zUb0GQ2UAGWjwjchJhgFPhlnHGRme6MMbqaG20mDqRz MiktX/dcXsQqwZDIEQZ4n8HisK64O0xIMpSqhQ4u6TU6QAA/BEteNfq7NcAl+ZgxLvBN x4MvsdL1iqLuUWmz1bgKPJmM/kpWfmh+us8jMEnqixrOP3gXiROx/sOnRQ+9TzJVwBsy nKWpvgNNHF9MfyezQU97/2mUDCYaLQ9JuFGKRctyC6ztlAJF6VNPJEbfZ9ldcGqfwhcS 4YKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776180311; x=1776785111; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zrnw2LUyNaW2ANHpqLyYF8hEjA5tKqE1HoISMvx1f9M=; b=XXrRMbCd6JNkresIAFb/+Cn9Va3ZPUO2uOH2ja5GpnbfO0aH1BOLeX88gmbjKETQOB zhrwWr1vsJGiOumaght+rFnmcrk2m7l+X931GSQUnqABDgEKjrAuUpcPNemV9gvyXoys qsv8HXLWaDlolRRlP1oqI+tvEzVU9zQ9/BIAQLXtgKetK/EyNFT8nlULDI0p+Xkr4c0v H5Xt6sqkCuqr3HrLY7HmedJcfRkW1qO1WysLoARYsWUb49i8V7ZVwPMl54wLcFj6tzeI ZwEZSshmxcEoCqN4qWNFAY3snYCaI2Yn9ozWZhrSFpxl2aNGF8FQFtvojlgdZaZKYt52 nkiQ== X-Forwarded-Encrypted: i=1; AFNElJ/BYL92SLxsRGvunfVNHfjoBYvL/PeOW/pZWmwWMwYp6l8b8DC3cMNImZdOSg7GL/sTg3DpzuWieQYylf4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6DEoNlOD9YR/jXlrhct1wU/Zq7I9QclkLd8bmYNla9+5ZkCtX CeY03Zr1oKU6CF2xdufBEwXemeeQPfoNo2JJIHbahYJpvv7NrqqgyRazwvdG1w== X-Gm-Gg: AeBDievTOtSm7IAumcz0G7RBLxfjyISxzjZethdxBdiPwTuU5Kk0uIiw0xP9N9VdjRU QV/HpUi2ZJrwTM6YbZCUGIY9phrQ7SYeIza/YCFpRLMKosGmjE8kq7mBEgxI1AT3jMhLIspSeOG kLZjbHGJLK8Y2Bx2+vZmN2OFDaImtqCzNeymDJwx+aabHqpSiTtGlxh8X0vuinCVx/PmLJxWQUi iJVHdsLTz1PKAvY4RncmHbSb5QaPohiqdRVBBYemoLtQxA7+B9B0pGhWaICcpMR2RKrlKQ2jQxx atAjL5GrXmbEkkJqQM/HNh5+tywIW3KF1sGqTg3TBfbn/BBXExREJBUsxXZfiMqycIX7WCm+/d3 dToagtc/V+RivjKtwCdK0V/23OG/Erw0ude4vYfcxdJVtv0DgJQKVO4LLbOgikpmTKbDlgp7cAk uqVwGkoN0tALFhPmQwciuWTRZ/8pJkPJZYXmStTDQZJxDYoGJHWnDL0cFfkQ== X-Received: by 2002:a17:903:fa7:b0:2b2:680c:2193 with SMTP id d9443c01a7336-2b2d5a52b4bmr175610315ad.31.1776180310731; Tue, 14 Apr 2026 08:25:10 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ac12:a4a1:b77e:33f7:8c2a:3842]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b461d599a1sm58714765ad.0.2026.04.14.08.25.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 08:25:10 -0700 (PDT) Date: Sun, 12 Apr 2026 22:15:42 +0530 From: Sanjay Chitroda To: David Lechner , jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org CC: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v5_4/5=5D_iio=3A_ssp=5Fsensors=3A_us?= =?US-ASCII?Q?e_devm_APIs_for_mutex_and_IRQ_resources?= User-Agent: Thunderbird for Android In-Reply-To: <6479ec7b-a8b5-4154-8857-9e7c9af7ecc4@baylibre.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> <20260406080852.2727453-5-sanjayembedded@gmail.com> <438F2B61-7F4D-4488-82D0-E1EE23FBF766@gmail.com> <6479ec7b-a8b5-4154-8857-9e7c9af7ecc4@baylibre.com> Message-ID: <9E69501A-C05A-4B76-A766-5C55CD0478CA@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12 April 2026 12:01:24=E2=80=AFam IST, David Lechner wrote: >On 4/11/26 6:35 AM, Sanjay Chitroda wrote: >>=20 >>=20 >> Also, I observed that in remove() path, there is duplicate of following= with ssp_disable_wdt_timer(): >>=20 >> static void ssp_remove(struct spi_device *spi) >> { >> =2E=2E=2E >> ssp_disable_wdt_timer(data); >>=20 >> =2E=2E=2E=2E >>=20 >> timer_delete_sync(&data->wdt_timer); >> cancel_work_sync(&data->work_wdt); >>=20 >> =2E=2E=2E >> } >>=20 >> static void ssp_disable_wdt_timer(data)(struct spi_device *spi) >> { >> timer_delete_sync(&data->wdt_timer); >> cancel_work_sync(&data->work_wdt); >> } >>=20 >> At first glance looks redundant, do we require both ? > >No, this sounds like a double-free bug=2E > Hi David, Thank you for your input=2E I have created a change to drop duplicated wdt timer and work cleanup=2E W= ill send changes in next series in few days=2E