mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhang warden <zhangwarden@gmail.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>, Miroslav Benes <mbenes@suse.cz>,
	Jiri Kosina <jikos@kernel.org>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/1] livepatch: Add "stack_order" sysfs attribute
Date: Sun, 6 Oct 2024 16:32:34 +0800	[thread overview]
Message-ID: <9E708EDA-C28E-40BB-8B5F-703132E95096@gmail.com> (raw)
In-Reply-To: <20241003152516.fzga2uaivzg57q4s@treble>



> On Oct 3, 2024, at 23:25, Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> 
> On Thu, Oct 03, 2024 at 10:59:11PM +0800, zhang warden wrote:
>>> This attribute specifies the sequence in which live patch modules
>>> are applied to the system. If multiple live patches modify the same
>>> function, the implementation with the highest stack order is used,
>>> unless a transition is currently in progress.
>> 
>> This description looks good to me. What's the suggestion of 
>> other maintainers ?
> 
> I like it, though "highest stack order" is still a bit arbitrary, since
> the highest stack order is actually the lowest number.
> 
> -- 
> Josh

How about:

This attribute specifies the sequence in which live patch module 
are applied to the system. If multiple live patches modify the same
function, the implementation with the biggest 'stack_order' number
is used, unless a transition is currently in progress.

Regards.
Wardenjohn.

  reply	other threads:[~2024-10-06  8:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-29 14:43 [PATCH V3 0/1] " Wardenjohn
2024-09-29 14:43 ` [PATCH V3 1/1] " Wardenjohn
2024-09-30 23:26   ` Josh Poimboeuf
2024-10-03  6:26     ` zhang warden
2024-10-03 11:52       ` Petr Mladek
2024-10-03 14:59         ` zhang warden
2024-10-03 15:25           ` Josh Poimboeuf
2024-10-06  8:32             ` zhang warden [this message]
2024-10-02 11:44 ` [PATCH V3 0/1] " Miroslav Benes
2024-10-03  8:09   ` zhang warden
     [not found]   ` <CADDyLDU4Hsp-FCjocEyfEmY6-JOKeH+YjsBfUr+xbO=opOEhgw@mail.gmail.com>
2024-10-03 11:56     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9E708EDA-C28E-40BB-8B5F-703132E95096@gmail.com \
    --to=zhangwarden@gmail.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®