From: "Hawkins, Nick" <nick.hawkins@hpe.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Verdun, Jean-Marie" <verdun@hpe.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v5 2/5] gpio: gxp: Add HPE GXP GPIO PL
Date: Thu, 20 Jul 2023 20:26:51 +0000 [thread overview]
Message-ID: <9EABEF68-9261-416F-87FA-6DFDF7A5376A@hpe.com> (raw)
In-Reply-To: <CAMRc=MfaEfaZ7yYrFtc+XChzPX1C1AV1xAZPRZyJKA+z7D6-vw@mail.gmail.com>
> > +
> > +/*
> > + * When an interrupt fires for a PSU config change
> > + * there is a need to know the previous PSU configuration
> > + * so that the appropriate gpio line is interrupted for
> > + * the correct PSU. In order to keep this variable up to
> > + * date it is global so that it can be set at init and
> > + * each time the interrupt fires.
> > + */
> > +u8 psu_presence;
> I'm not buying it. There's no user of this variable outside of this
> compilation unit, is there? If there was - the name should have some
> prefix but even then, I don't see a need for this to be global. Why
> don't you put it in struct gxp_gpio_drvdata?
Hi Bart,
You are correct this should not be global. It will be placed in
gxp_gpio_drvdata.
Thank you for catching this and the assistance,
-Nick Hawkins
next prev parent reply other threads:[~2023-07-20 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 19:45 [PATCH v5 0/5] ARM: Add GPIO support nick.hawkins
2023-07-05 19:45 ` [PATCH v5 1/5] dt-bindings: gpio: Add HPE GXP GPIO nick.hawkins
2023-07-06 6:22 ` Krzysztof Kozlowski
2023-07-06 14:12 ` Hawkins, Nick
2023-07-06 19:05 ` Rob Herring
2023-07-05 19:45 ` [PATCH v5 2/5] gpio: gxp: Add HPE GXP GPIO PL nick.hawkins
2023-07-20 15:12 ` Bartosz Golaszewski
2023-07-20 20:26 ` Hawkins, Nick [this message]
2023-07-05 19:45 ` [PATCH v5 3/5] dt-bindings: hwmon: hpe,gxp-fan-ctrl: remove fn2 and pl registers nick.hawkins
2023-07-05 19:45 ` [PATCH v5 4/5] hwmon: (gxp_fan_ctrl) Provide fan info via gpio nick.hawkins
2023-07-05 19:45 ` [PATCH v5 5/5] MAINTAINERS: hpe: Add GPIO nick.hawkins
2023-07-16 21:12 ` [PATCH v5 0/5] ARM: Add GPIO support Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9EABEF68-9261-416F-87FA-6DFDF7A5376A@hpe.com \
--to=nick.hawkins@hpe.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®