From: Kumar Gala <galak@codeaurora.org>
To: Olof Johansson <olof@lixom.net>
Cc: "arm@kernel.org" <arm@kernel.org>,
Kevin Hilman <khilman@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Lina Iyer <lina.iyer@linaro.org>,
Saravana Kannan <skannan@codeaurora.org>,
Olav Haugan <ohaugan@codeaurora.org>,
Vikram Mulukutla <markivx@codeaurora.org>
Subject: qcom firmware / scm interface (was Re: [GIT PULL] qcom SoC changes for v3.20)
Date: Wed, 4 Feb 2015 14:45:31 -0600 [thread overview]
Message-ID: <9F29C4A8-BD35-4E87-9765-56597A38F134@codeaurora.org> (raw)
In-Reply-To: <CAOesGMht4VaNgwr5rOyher081Vk7w_HKTMeOm677rEAkOcCPAg@mail.gmail.com>
>>> I'd be OK with merging this, send a request and tag. Would that let
>>> the DRM folks make progress too?
>>
>> Will do, I don’t think it will address the DRM folks needs as they need access to make firmware calls from the DRM driver.
>>
>>> If you need a common place for this, drivers/firmware seems like a
>>> better home than drivers/soc.
>>
>> Agreed, what’s you take than on moving to use firmware_ops as defined in arch/arm and extended it or just leaving this as a qcom specific firmware interface?
>
> Are there any other SoCs out there with similar requirements on
> firmware interfaces? I think most of them so far have been fairly
> simple compared to the complexity of the qualcomm firmware.
>
> Would it make sense to use firmware_ops for the common pieces and have
> direct smc calls for the rest? I'm not sure that would buy us all that
> much. Hm.
>
> Well, at least it's an internal implementation detail. If we move it
> now and find a better way to do it down the road it can be refactored.
So I’ve been looking at the ARM firmware_ops and I’m not sure it makes much sense to try and contort either the QCOM SCM interface to match or the other way around. The firmware_ops don’t really match what the qcom scm interface exposes and trying to make it would just seem to make the firmware_ops to QCOM specific to be of any value.
I’ll look at cleaning up the SCM code and moving it to drivers/firmware instead of drivers/soc/qcom if that is more desirable.
- k
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-02-04 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 18:27 [GIT PULL] qcom SoC changes for v3.20 Kumar Gala
2015-01-22 1:15 ` Olof Johansson
2015-01-22 17:02 ` Kumar Gala
2015-01-23 3:00 ` Olof Johansson
2015-01-23 16:22 ` Kumar Gala
2015-01-23 18:43 ` Olof Johansson
2015-01-25 16:03 ` Rob Clark
2015-01-25 16:11 ` Sean Paul
2015-02-04 20:45 ` Kumar Gala [this message]
2015-02-04 20:49 ` qcom firmware / scm interface (was Re: [GIT PULL] qcom SoC changes for v3.20) Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F29C4A8-BD35-4E87-9765-56597A38F134@codeaurora.org \
--to=galak@codeaurora.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=khilman@linaro.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=ohaugan@codeaurora.org \
--cc=olof@lixom.net \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®