From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 320DB2FCBE3 for ; Mon, 15 Sep 2025 10:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757932247; cv=none; b=ChdlXtMNDtkiXYcR6UX4BGDqFtO9C7eSgLGISe0H/+SxQU8Kb+n5vZYU3ZRzUSxbQQIatB0x+knwz00JjPUNnPR/OFFl4LF3zRUSO4lo3wh1vQpRh5bLg30pssZlS8qgaJ3lUTAmyhgVICcpgIROYM1wsEWWGvok3UO5kBWEnYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757932247; c=relaxed/simple; bh=zY7JI7hDmtHnYscMcs6+BbCMIvxvauO2CVcScH3sN0Y=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=aq8V45y8KSKohNnXNNQsu6415k00IPaCJDLs5gxqNNZLTttNYWYD8ummMGdO6Ibp5vGNgEv6QSCZsU5YQwdrV75YlgiyJqIckgs+Ls9dNmhb1mf87cVqA+SewhlKkhK3tfqv9j5VLBY5GLSAkzwmGD8q3eoe51HGqMgdCn4p60Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=V1BHcmxb; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="V1BHcmxb" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1757932233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jdb8MAzJ69Crza7fkEstwRRVIV34/bxmK/xuu8MGxcM=; b=V1BHcmxbOiJwcyYkyAvWjYh61UIhQSWPQHb1XMLdUh2Z096n8Ayr8bciUQia4p7btjsitU QgDBXE+e6aLAf14xunvHlLUfCGEqsVI7Fpsnhkyn/QMlhJrphce486mjVIkmijWJwu/8NU g5sKmtSkEPaIqtkoPmj7tAjULe6keb0= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH] initrd: Fix logged Minix/Ext2 block numbers in identify_ramdisk_image() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: <20250915043141.GM1587915@frogsfrogsfrogs> Date: Mon, 15 Sep 2025 12:30:20 +0200 Cc: David Disseldorp , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <9FA25B6B-4B04-4A35-90E2-8537C1E228E6@linux.dev> References: <20250913103959.1788193-1-thorsten.blum@linux.dev> <20250915122146.56f66eb2.ddiss@suse.de> <20250915043141.GM1587915@frogsfrogsfrogs> To: "Darrick J. Wong" X-Migadu-Flow: FLOW_OUT On 15. Sep 2025, at 06:31, Darrick J. Wong wrote: > On Mon, Sep 15, 2025 at 12:21:46PM +1000, David Disseldorp wrote: >> Hi Thorsten, >> >> On Sat, 13 Sep 2025 12:39:54 +0200, Thorsten Blum wrote: >> >>> Both Minix and Ext2 filesystems are located at 'start_block + 1'. Update >>> the log messages to report the correct block numbers. >> >> I don't think this change is worthwhile. The offset of the superblock >> within the filesystem image is an implementation detail. > > ...and even if logging the detail is useful, for ext* the superblock is > always at byte offset 1024, no matter which block (0 or 1) that is. All logs ignore the individual filesystem offsets and only print the starting block. This may not be particularly useful information, but the printed starting blocks for minix/ext2 are off by one compared to the others, which is at least confusing. Since initrd seems to be on its way out anyway, it's probably not worth changing this. Thanks, Thorsten