From: Kumar Gala <galak@kernel.crashing.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "Timur Tabi" <timur@freescale.com>, <linuxppc-dev@ozlabs.org>,
<hjk@hansjkoch.de>, <gregkh@suse.de>,
<linux-kernel@vger.kernel.org>,
"Jiang Kai-B18973" <B18973@freescale.com>
Subject: Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems
Date: Thu, 13 Oct 2011 10:50:17 -0500 [thread overview]
Message-ID: <9FAA2091-2FED-4B44-9224-6C735CF51D2C@kernel.crashing.org> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AE7E@saturn3.aculab.com>
On Oct 13, 2011, at 10:37 AM, David Laight wrote:
>
>> Kumar Gala wrote:
>>>>>>> + phys_addr_t addr;
>>>>>
>>>>> Please add a comment here saying:
>>>>>
>>>>> 1) That 'addr' can be a virtual or physical address
>>> The code and everything else makes that clear
>>
>> I'm sorry, but I have to strongly disagree here. It is *NOT*
>> clear that a variable of type 'phys_addr_t' can hold something
>> that is not a physical address.
>
> Since there is a discriminating field, could a union be used?
> At a guess the type of the address is constrained between
> produces and consumer??
Uugh.
I'll add a comment to uio_mem.
- k
prev parent reply other threads:[~2011-10-13 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 20:57 Kumar Gala
2011-10-13 14:37 ` Tabi Timur-B04825
2011-10-13 15:32 ` Kumar Gala
2011-10-13 15:34 ` Timur Tabi
2011-10-13 15:37 ` David Laight
2011-10-13 15:41 ` Timur Tabi
2011-10-13 15:50 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9FAA2091-2FED-4B44-9224-6C735CF51D2C@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=B18973@freescale.com \
--cc=David.Laight@ACULAB.COM \
--cc=gregkh@suse.de \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®