From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C86C2BA1A for ; Tue, 7 Apr 2020 16:33:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71B2A2072A for ; Tue, 7 Apr 2020 16:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728391AbgDGQd2 (ORCPT ); Tue, 7 Apr 2020 12:33:28 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:46496 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbgDGQd2 (ORCPT ); Tue, 7 Apr 2020 12:33:28 -0400 Received: from marcel-macbook.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id E88BACECD8; Tue, 7 Apr 2020 18:43:00 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH v2] Bluetooth: debugfs option to unset MITM flag From: Marcel Holtmann In-Reply-To: <20200407122522.v2.1.Ibfc500cbf0bf2dc8429b17f064e960e95bb228e9@changeid> Date: Tue, 7 Apr 2020 18:33:26 +0200 Cc: linux-bluetooth , Johan Hedberg , Archie Pusaka , "David S. Miller" , Jakub Kicinski , LKML , netdev@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <9FED3BF8-B784-4E71-86C2-5BFACB18F1AA@holtmann.org> References: <20200407122522.v2.1.Ibfc500cbf0bf2dc8429b17f064e960e95bb228e9@changeid> To: Archie Pusaka X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Archie, > The BT qualification test SM/MAS/PKE/BV-01-C needs us to turn off > the MITM flag when pairing, and at the same time also set the io > capability to something other than no input no output. > > Currently the MITM flag is only unset when the io capability is set > to no input no output, therefore the test cannot be executed. > > This patch introduces a debugfs option to force MITM flag to be > turned off. > > Signed-off-by: Archie Pusaka > --- > > Changes in v2: > - Rename flag to HCI_FORCE_NO_MITM > - Move debugfs functions to hci_debugfs.c > - Add comments on not setting SMP_AUTH_MITM > > include/net/bluetooth/hci.h | 1 + > net/bluetooth/hci_debugfs.c | 46 +++++++++++++++++++++++++++++++++++++ > net/bluetooth/smp.c | 15 ++++++++---- > 3 files changed, 57 insertions(+), 5 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel