mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: linux-media@vger.kernel.org, Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Rik van Riel <riel@surriel.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 16/17] media: rc: After rc_unregister_device() timers can be re-armed
Date: Fri,  4 Sep 2026 14:07:44 +0100	[thread overview]
Message-ID: <9a0007543dea39b08f2c6124e005ddc90afa10a2.1788526920.git.sean@mess.org> (raw)
In-Reply-To: <cover.1788526920.git.sean@mess.org>

If rc_keydown() is called after rc_register_device(), then the timers
can be re-armed. Delete them again for a final time.

Fixes: dccc0c3ddf8f ("media: rc: fix race between unregister and urb/irq callbacks")
Signed-off-by: Sean Young <sean@mess.org>
Cc: stable@vger.kernel.org
---
 drivers/media/rc/rc-main.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 795ac0fe4858..a40d1bb75822 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -1785,6 +1785,11 @@ void rc_free_device(struct rc_dev *dev)
 	if (!dev)
 		return;
 
+	if (dev->input_dev) {
+		timer_delete_sync(&dev->timer_keyup);
+		timer_delete_sync(&dev->timer_repeat);
+	}
+
 	input_put_device(dev->input_dev);
 
 	put_device(&dev->dev);
-- 
2.55.0


  parent reply	other threads:[~2026-09-04 13:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1788526920.git.sean@mess.org>
2026-09-04 13:07 ` [PATCH v3 01/17] media: rc: Ensure registered is cleared in error path Sean Young
2026-09-04 13:07 ` [PATCH v3 02/17] media: rc: Ensure that rc_unregister_device() does not free input device Sean Young
2026-09-04 13:07 ` [PATCH v3 03/17] media: rc: Fix ABBA deadlock by making locks more fine grained Sean Young
2026-09-04 13:07 ` [PATCH v3 04/17] media: rc: Add missing locking for keymap Sean Young
2026-09-04 13:07 ` [PATCH v3 05/17] media: rc: Fix race between bpf(BPG_PROG_ATTACH) and device unregister Sean Young
2026-09-04 13:07 ` [PATCH v3 06/17] media: rc: mce_kbd: Fix inconsistent locking of keylock Sean Young
2026-09-04 13:07 ` [PATCH v3 07/17] media: ene_ir: Ensure teardown is done in the correct order Sean Young
2026-09-04 13:07 ` [PATCH v3 08/17] media: rc: Use binary search for adding or updating a scancode Sean Young
2026-09-04 13:07 ` [PATCH v3 09/17] media: rc: imon: Bind both interfaces via usb_driver_claim_interface() Sean Young
2026-09-04 13:07 ` [PATCH v3 10/17] media: ir_toy: Remove unused struct field Sean Young
2026-09-04 13:07 ` [PATCH v3 11/17] media: nuvoton-cir: " Sean Young
2026-09-04 13:07 ` [PATCH v3 12/17] media: ite-cir: Removed " Sean Young
2026-09-04 13:07 ` [PATCH v3 13/17] media: fintek-cir: Remove unused fields Sean Young
2026-09-04 13:07 ` [PATCH v3 14/17] media: mceusb: Remove unused field Sean Young
2026-09-04 13:07 ` [PATCH v3 15/17] media: serial_ir: Fix race condition where timer can be re-armed Sean Young
2026-09-04 13:07 ` Sean Young [this message]
2026-09-04 13:07 ` [PATCH v3 17/17] media: rc: Validate carrier range in LIRC_SET_REC_CARRIER ioctl Sean Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a0007543dea39b08f2c6124e005ddc90afa10a2.1788526920.git.sean@mess.org \
    --to=sean@mess.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=riel@surriel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®