From: Mukesh Ojha <mojha@codeaurora.org>
To: Ding Xiang <dingxiang@cmss.chinamobile.com>,
rubini@gnudd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/fmc: remove unneeded NULL check
Date: Thu, 28 Mar 2019 15:52:39 +0530 [thread overview]
Message-ID: <9a0194ef-2c45-3a29-2297-ee632779adb0@codeaurora.org> (raw)
In-Reply-To: <1553764997-26484-1-git-send-email-dingxiang@cmss.chinamobile.com>
On 3/28/2019 2:53 PM, Ding Xiang wrote:
> The variable will check in debugfs_remove_recursive, so
> the NULL check here is not needed
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> drivers/fmc/fmc-debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
> index 3293072..ab868a3 100644
> --- a/drivers/fmc/fmc-debug.c
> +++ b/drivers/fmc/fmc-debug.c
> @@ -168,6 +168,5 @@ int fmc_debug_init(struct fmc_device *fmc)
>
> void fmc_debug_exit(struct fmc_device *fmc)
> {
> - if (fmc->dbg_dir)
> - debugfs_remove_recursive(fmc->dbg_dir);
> + debugfs_remove_recursive(fmc->dbg_dir);
> }
prev parent reply other threads:[~2019-03-28 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 9:23 Ding Xiang
2019-03-28 10:22 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a0194ef-2c45-3a29-2297-ee632779adb0@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=dingxiang@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®