From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753540AbdAHQhw (ORCPT ); Sun, 8 Jan 2017 11:37:52 -0500 Received: from mout.web.de ([217.72.192.78]:52641 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752816AbdAHQhq (ORCPT ); Sun, 8 Jan 2017 11:37:46 -0500 To: Andrew Morton , George Zhang , "Kirill A. Shutemov" , Masahiro Yamada , Michal Hocko From: SF Markus Elfring Subject: [PATCH] VMCI: Use kmalloc_array() in qp_alloc_ppn_set() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <9a04914a-138b-3f5d-b82a-8043b2602bd9@users.sourceforge.net> Date: Sun, 8 Jan 2017 17:37:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:XJmIXOE994A6sXtOzp18eCMFvtS54a/BZyU6RkPM3geSylaB1pe 6urnMqifxQ3zWSWhw3dxwmIw3BaVScz7hmKpa+ogDQTq5mLKoCvcpgcGbwjo5PKl/KZunzo 5031tlBSLibBxihVu8e14T0jy/HOjgqhUQl/vpOOYo0VAU7HQBYnHN+dERSQCeIcBnb2rfI c1K0DggvTvYavFHoggdhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:cK4ZdJM4W6Q=:GwsdGFM63PBHdzo/jn8UiO whI8KZLNYBNiV7Z1oZfANcbL1StnebZqyTELQon9hxC1Dulx7a6YuoT7tEONJv+eVtBOmt2Rr J2n+hzeacU01uapr71sUMoIzRW6H1ow4PR/VkEc/fwjVbdHNnqsEuOCDFkcyGEY0ORky8lF6G G90w1IH/Pqju0IdHX2CKfciIQyq1iqliruIJFf2Swp7Q/0YsTu+lc5xU2wO7pprOB+TCvCqsg oYdm6X1v5LSh/nw8xj2Zpi1Ce4d/NGfNgl0Zv9gFJcoKOcyd3tBWreIZY24GzBhfHCC713U02 sLHoUUXNeAJsybSH3OZwDd/C/NWXD3fY4/twLLcrLF7qh1TjiJYvKdRbIp+Re9jRQ3gp7SSty oqPHdd5fKZJTrfvUye3/FGDXsNbfu5kYH4cpitxz4bL/VkwtfXIgYbUL1jHGV8bTdyR9zIVMr fSLEWHijlAF4a7Yc1vy4MYkqITbAIutFF93YZyrNwaHwIR8eG3avMF9mFdQn9usNJqEh/VgYR 10Jf72ET8ql7B36nRv0ORpEFwhsyKLacO5Zpf/bhzR3j5xvGitGW3zL3FEUBH4Isx+HGkn9xk rA3XVl5Fbx8IoU8jdL2ZO3LNef+Vl3sHiuOVb2BV9EFf8MK4rxXeuVKKwWAN9cgGACxP1OQS1 f+l/5iJaS9Dek7sA976/HQpQRtbS0tPLO8f8GzCGFG5S1iTk/RI5BcFup6mT/xOuObr00z1l1 FWtmSeyE7rWGIo9OwnG4WuFpqtJlcl+SWK+EfnQICNXelWnJMLTzSkXK1D1qO39dPQf3fTXQT 3uMY0hq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 8 Jan 2017 14:04:10 +0100 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/vmw_vmci/vmci_queue_pair.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c index 498c0854305f..7b5c8a89cc54 100644 --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c @@ -486,13 +486,15 @@ static int qp_alloc_ppn_set(void *prod_q, if (ppn_set->initialized) return VMCI_ERROR_ALREADY_EXISTS; - produce_ppns = - kmalloc(num_produce_pages * sizeof(*produce_ppns), GFP_KERNEL); + produce_ppns = kmalloc_array(num_produce_pages, + sizeof(*produce_ppns), + GFP_KERNEL); if (!produce_ppns) return VMCI_ERROR_NO_MEM; - consume_ppns = - kmalloc(num_consume_pages * sizeof(*consume_ppns), GFP_KERNEL); + consume_ppns = kmalloc_array(num_consume_pages, + sizeof(*consume_ppns), + GFP_KERNEL); if (!consume_ppns) { kfree(produce_ppns); return VMCI_ERROR_NO_MEM; -- 2.11.0