From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63C03500950; Sat, 10 Jan 2026 11:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768044997; cv=none; b=D/4T5vabruOLlstQf3qAYvNmZFfEey8JJWP5JqtdKbUctERycK2SE9dipFwt3oPywW+DQKlRYRmP9TBa9pwRCn5699ZFo4iqwZ8cu/kSsfepbd/3o4IC59z5cPPB6l/mk3QBAvvj97Nkt3XxuKL+P2hwDT/Pg7/+T80GFM42/nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768044997; c=relaxed/simple; bh=hFmk1VD0wsbSjaFH/RZ3HHi9KAL8aML96uYpgGNPOnw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PSlWgMTN4XJxQfNA2tQfKR9W7LxKsGqVp2GFG5sscgAjX3JXhHQPOtyLNCquZqYfuztySkCvkfVg1AKhrAYMnMHm7FSqHBeixhQYnNFYi3hwW4VOV4XZ/vOVwDTi5fHpmQCyvbTfM93e6J28Ya42/AIVAQ+l7nCY83S5vgJRkEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vDrJfIAi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vDrJfIAi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95096C4CEF1; Sat, 10 Jan 2026 11:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768044996; bh=hFmk1VD0wsbSjaFH/RZ3HHi9KAL8aML96uYpgGNPOnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vDrJfIAiURhOO1bdyBXeF4sTII+rlZAxGBqWg5F/VJM4UFVVm2txe8mpUcimK3tcJ jAz+y6pH4YSyB4gTG4iIq8LT0dcVtsw2e+NNiRTcqDxNAkbATT3aYptYNxX8QqIKMl euUhvhFwPkfFSYSnU4KulHSLUOgxA9fGXAOc2w2kCcSwOxZxtxW4facDaS5HSpD8Vz jWeuNUoFRm25qgnqsKuPt4Da+9urNgC1ljlPrCoObBWQxfGYsyMLTIfvTFF7h8U/Oh yJYt3794581qZCkBu6kNoVL4+KkvYF3gPTIORGrPnb6dRlQE8lrknCHsRDLtcVGT+q 8K6aeHPAXDe4w== Message-ID: <9a0590d7-6d3f-422d-8db8-a30845180298@kernel.org> Date: Sat, 10 Jan 2026 12:36:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] arm64: dts: apple: Add integrated USB Type-C ports To: Janne Grunau Cc: asahi@lists.linux.dev, Neal Gompa , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , linux-kernel@vger.kernel.org, Hector Martin , R References: <20260109-apple-dt-usb-c-atc-dwc3-v1-0-ce0e92c1a016@jannau.net> Content-Language: en-US From: Sven Peter In-Reply-To: <20260109-apple-dt-usb-c-atc-dwc3-v1-0-ce0e92c1a016@jannau.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/9/26 15:07, Janne Grunau wrote: > Now that all dependencies for USB 2.0 and 3.x support are either merged > (tipd changes in v6.18, dwc3-apple in v6.19-rc1) or in linux-next (Apple > Type-C PHY) prepare device tree changes to expose the ports. > > Each port on Apple silicon devices is driven by a separate collection of > hardware blocks. For USB 2.0 and 3.x the collection consists of: > - Apple Type-C PHY, combo PHY for USB 2.0, USB 3.x, USB4/Thunderbolt and > DisplayPort > - Synopsys Designware dwc3 USB controller > - two DART iommu instances for dwc3 > - CD321x USB PD controller (similar to Ti's TPS6598x series) > > The CD321x nodes are already present so this series add the remaining > devices nodes, typec connector nodes and connections between all > components. > > The devices expose except for a few exceptions noted below all ports. M1 > and M2 have two ports, M1 and M2 Pro and Max have four ports and > M1 and M2 Ultra have eight ports. > The Pro and Max based Macbook Pros use only three ports. The fourth port > is used as DisplayPort PHY to drive a HDMI output via an integrated > DP to HDMI converter. > The Ultra based Mac studio devices only use six ports. The third and > fourth port on the second die is completely fused off. > > The changes for t600x and t602x are in a single commit since the devices > share .dtsi files across SoC generations due to their similarity. > > Depends on commit c1538b87caef ("dt-bindings: phy: Add Apple Type-C > PHY") in linux-phy's [1] next branch for `make dtbs_check` to pass. > checkpatch warns about the undocumented DT compatible strings > "apple,t8112-atcphy", "apple,t6000-atcphy" and "apple,t6020-atcphy" but > not about "apple,t8103-atcphy". I don't under why it doesn't warn about > the last. "apple,t8103-atcphy" is only found in the added devicetree > files and nowhere else in v6.19-rc1. > > Tested on top of next-20260106 on M1, M2, M1 Max and M2 Pro Mac mini / > Mac studio and a few fixes for dwc3-apple and atc [2, 3, 4, 5]. > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/ [1] > Link: https://lore.kernel.org/asahi/20260104-atcphy-tunable-fix-v2-1-84e5c2a57aaa@kernel.org/ [2] > Link: https://lore.kernel.org/asahi/20260108-atcphy-coldboot-fix-v1-1-01c41c6e84f2@kernel.org/ [3] > Link: https://lore.kernel.org/asahi/20260108-dwc3-apple-usb2phy-fix-v1-1-5dd7bc642040@kernel.org/ [4] > Link: https://lore.kernel.org/asahi/20260109-apple-dwc3-role-switch-v1-1-11623b0f6222@jannau.net/ [5] > Signed-off-by: Janne Grunau > --- thanks for doing this tedious work! This all looks good to me and the t8103 changes have been running fine for a while on my machine now. I will give it another week or so on LKML before merging it! Tested-by: Sven Peter # M1 mac mini and macbook air Reviewed-by: Sven Peter Best, Sven