From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69DB41841; Fri, 12 Jan 2024 03:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Hx2nZSOr" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40C1psqV015208; Fri, 12 Jan 2024 03:01:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=1HnwaWt5Jt6hzcai74PPn/qYhMYP3aPg+XkVo/AFp8M=; b=Hx 2nZSOrpuD9vPUoZYymONQDeplE+BwfeLysGqQgfGxWqBu80h2SwS2G4wqFzwJOwI +cMzwShWu5g/SKmqVDket+WWXLKHTijf64KXy8znyZPR17Zbs0ebezivNvyNVjMB WVtIlH5yC+HMyAX1EuCie+J1Nf2pWsn5HSlA0MVIzOfcUh9TH+hruDgAmv5zS6Uk l0s/wOmrtDnjLGs7f8gS4p2lUIjwUJYvRRl9u4icj/okb4OoCAh8C7kV03h0CUV6 6aYcs+UYCYWABA2cyuMBIqx1weFI/jZfEOcw4idiX4cEOg8H8M9w4xRtN2H9DoCi bEgsweP08WE+VscKwUZQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vjv4jr4ja-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 03:01:40 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40C31dQE009931 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 03:01:39 GMT Received: from [10.238.139.231] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 11 Jan 2024 19:01:35 -0800 Message-ID: <9a148f86-1a9c-4b67-aaa4-1f08ff31e46c@quicinc.com> Date: Fri, 12 Jan 2024 11:01:35 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v3] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs. To: Dmitry Baryshkov CC: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , References: <20240111-lpg-v3-1-811c9e82dae4@quicinc.com> From: hui liu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: yPELrStZmphBfOPPVmMhqhlox21CRam2 X-Proofpoint-ORIG-GUID: yPELrStZmphBfOPPVmMhqhlox21CRam2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1011 mlxscore=0 mlxlogscore=873 lowpriorityscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401120019 On 1/11/2024 11:38 AM, Dmitry Baryshkov wrote: > On Thu, 11 Jan 2024 at 04:54, Hui Liu via B4 Relay > wrote: >> >> From: Hui Liu >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu >> --- >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. > > The commit message is the same as in v2. > > Commit subject mentions non-existing board, "qcs6490-idp" > >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..f801144a1556 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include >> #include >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,30 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = ; >> + label = "red"; > > Is there any reason why Krzysztof's review for v2 was ignored? Let me > repeat it here: "Drop labels. You already have color, so you miss > function." I will update it. > > >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = ; >> + label = "green"; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = ; >> + label = "blue"; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >> -- >> Hui Liu >> >> > >