From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFDE7338581 for ; Tue, 17 Feb 2026 14:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771337399; cv=none; b=TkojlPCRrwxKDzBr/wl+IEFCRWE9I/OLdR7p46oNngRLvaaJ+6od2u3wwfr2hs32+CrthbQ3yJntnUVmYpATJESWIi2nWeaB1TZhjuY6enmDu3hQc09v2K9N04jLsZuIViTPXYsOavNXSuUCdGeDNmKTWISNkhXJ/umt/hqKMwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771337399; c=relaxed/simple; bh=/jyvLfP/QBMizw9HkoY82Vlo6F/zdu08l7YEVLT9TK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M4lGYhJEl7MnbaIA1D1VQv7iENiu7E13ZYTc7LgvOqSiF4p7u94DxyisQFW7BRWXf3ZCNdCTJAwiEw3AOM/WIzIpyCCIy+uR/9diIKfE5ib65XQzDwPUrccNNRsBYuSiiOkY3gJFq45U8THJuHzOPQXTpnN8FIl0V3C6bV2xMao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yqo/n1+t; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yqo/n1+t" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-65c20dc9577so1398333a12.2 for ; Tue, 17 Feb 2026 06:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771337396; x=1771942196; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ev0baLIks11CklQ1arlG40s9hBdfba5EjCldYEhDhHc=; b=yqo/n1+tdHsNpJhtkZz8EviYOVCUFUMoI1egstfQl2qaoIQglcQq1+JKyNEs5bxIPA +fs3iiqa1FhVyVcCt0TXsx7BQBshoM5Oaq4CC4BXT4s9+BQk+QRx785G+YHU2dKet8qW aNoyaN0DD4lBQHfTuhpTfdUsT28PU5GtHloqbv8LJsb0qVdkmTai4m5NgcRrUBVWLw3z /HO7tXDv/szBm5iaEfgaoSlG3+8SotEaWzd201GGzqaLzBMVTHhNeHuvUJXKexNESfHA BqAeuis5R2P0uY0lCK2VZq8SwOdCobzgEGdco665D0NJJOnx9dvI7bd+akNrd4i0JMcn slyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771337396; x=1771942196; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ev0baLIks11CklQ1arlG40s9hBdfba5EjCldYEhDhHc=; b=KP2sAT769iEk++uNLN2wSFvwtjZiBq9u2+JgRat/4fjI1D3REsBS3sUfQFdfYgKkKM DjV/wQ+o8Pg0q4sOJpu2mFws9Fu/V7ISanw2eGQlfXmNryxJO0/TMSBAsnwKFhmwy7pE FSWQOsyfXLg/+kwQPwgoxQ3GNLyZOTFaMtM4EbPJ5OQ53NqehvNy+X41BDHk9GFj0qMS qca0Zsktb86+JJUeLRViY2jnE7QaUrKr4XDcdWi71WEGoiy0+15O69l3hApLgmwmSN7U 3OHzTW5/+6s++7fCaRgVkcoLvVDR0n0y8gtljVgi4hfb3SR0uoQHXz0vwP+oeQRioBTk Fhqg== X-Forwarded-Encrypted: i=1; AJvYcCUDupM4gAxok40LeThBaoY67ZZ2M7rFf9a2iQcxVYPNwUHTuFF8zN5vufqjm5Hupd3wSC/nMxa5mCIFCDk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi1FVhawfXHL1zkKveODEWcZxnkxylBXhDQ76I+KivQFc1WLTM vy7cypR3WYFqByEklNVlz6slscMVPzzKTytMi/L6G8P/ztNpNIG0CyRgHTcDr9q8FHk= X-Gm-Gg: AZuq6aJ0BGG9Cp91m9SYpyxxE1uDLvw5V7bsYmLgC9suEQa2fAalOR4+T5aCejkp090 Anafz00tv/IBFCqyUQIUfVNhf57BYQN9ne+nx+1/nY4d+zufUKCpy9g8khnv0bVne+jsfp7o3Qn DnrdTllkZ+nThWW5Ef+IA92CMX1LNhqF/igdvwglLhTERU//am6mYiBp01XkYQp8OlQDEELVwJU pIkeICeSwaxEdMI7nY2w9ALk3tVX55UUCAvn6N4ZSF+/qkg5+VorDiZXIUxZxF2mXZbuszqsfxt d9d0qHypoh0Se6b8MzS84WIQIc8re8vfPlGYrgzdemQwYRpoJr8UKDQ/liTCzt42tHQrRyePBOz DgSFWPHB6KxTxwvsxf5rKLYfxv75iKOUo1oRRNtnOHMLSBFA2yDqddnso5ZYx0N3+9q3YKsTZ8E FRKdaQVlHdKXxkeM1sbMNr3YBInC8wRkX0IwR5whA= X-Received: by 2002:a17:907:7fa5:b0:b87:1d71:f44d with SMTP id a640c23a62f3a-b8facca14bemr830289966b.11.1771337395929; Tue, 17 Feb 2026 06:09:55 -0800 (PST) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad3e39ebsm2421950a12.18.2026.02.17.06.09.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 06:09:55 -0800 (PST) Message-ID: <9a16463e-c2d9-4ab9-bd1a-a9c6e7981412@linaro.org> Date: Tue, 17 Feb 2026 14:09:53 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 linux-next] perf parse-events: Fix big-endian 'overwrite' by writing correct union member To: Thomas Richter Cc: agordeev@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, namhyung@kernel.org, irogers@google.com References: <20260217131456.4085419-1-tmricht@linux.ibm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260217131456.4085419-1-tmricht@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/02/2026 1:14 pm, Thomas Richter wrote: > v1 -> v2: Add comments from James Clark and Ian Rogers > v2 -> v3: Improve switch statement in add_config_term() > v3 -> v4: Fix clang warnings > > The "Read backward ring buffer" test crashes on big-endian (e.g. s390x) > due to a NULL dereference when the backward mmap path isn't enabled. > > Reproducer: > # ./perf test -F 'Read backward ring buffer' > Segmentation fault (core dumped) > # uname -m > s390x > # > > Root cause: > get_config_terms() stores into evsel_config_term::val.val (u64) while later > code reads boolean fields such as evsel_config_term::val.overwrite. > On big-endian the 1-byte boolean is left-aligned, so writing > evsel_config_term::val.val = 1 is read back as > evsel_config_term::val.overwrite = 0, > leaving backward mmap disabled and a NULL map being used. > > Store values in the union member that matches the term type, e.g.: > /* for OVERWRITE */ > new_term->val.overwrite = 1; /* not new_term->val.val = 1 */ > to fix this. Improve add_config_term() and add two more parameters for > string and value. Function add_config_term() now creates a complete node > element of type evsel_config_term and handles all evsel_config_term::val > union members. > > Impact: > Enables backward mmap on big-endian and prevents the crash. > No change on little-endian. > > Output after: > # ./perf test -Fv 44 > --- start --- > Using CPUID IBM,9175,705,ME1,3.8,002f > mmap size 1052672B > mmap size 8192B > ---- end ---- > 44: Read backward ring buffer : Ok > # > > Fixes: 159ca97cd97c ("perf parse-events: Refactor get_config_terms() to remove macros") > Signed-off-by: Thomas Richter > Reviewed-by: Jan Polensky > Cc: James Clark > Cc: Ian Rogers > --- > tools/perf/util/parse-events.c | 82 +++++++++++++++++++++++++++------- > 1 file changed, 65 insertions(+), 17 deletions(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index b9efb296bba5..7b4629625b1e 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1117,7 +1117,7 @@ static int config_attr(struct perf_event_attr *attr, > > static struct evsel_config_term *add_config_term(enum evsel_term_type type, > struct list_head *head_terms, > - bool weak) > + bool weak, char *str, u64 val) > { > struct evsel_config_term *t; > > @@ -1128,8 +1128,62 @@ static struct evsel_config_term *add_config_term(enum evsel_term_type type, > INIT_LIST_HEAD(&t->list); > t->type = type; > t->weak = weak; > + > + switch (type) { > + case EVSEL__CONFIG_TERM_PERIOD: > + case EVSEL__CONFIG_TERM_FREQ: > + case EVSEL__CONFIG_TERM_STACK_USER: > + case EVSEL__CONFIG_TERM_USR_CHG_CONFIG: > + case EVSEL__CONFIG_TERM_USR_CHG_CONFIG1: > + case EVSEL__CONFIG_TERM_USR_CHG_CONFIG2: > + case EVSEL__CONFIG_TERM_USR_CHG_CONFIG3: > + case EVSEL__CONFIG_TERM_USR_CHG_CONFIG4: > + t->val.val = val; > + break; > + case EVSEL__CONFIG_TERM_TIME: > + t->val.time = val; > + break; > + case EVSEL__CONFIG_TERM_INHERIT: > + t->val.inherit = val; > + break; > + case EVSEL__CONFIG_TERM_OVERWRITE: > + t->val.overwrite = val; > + break; > + case EVSEL__CONFIG_TERM_MAX_STACK: > + t->val.max_stack = val; > + break; > + case EVSEL__CONFIG_TERM_MAX_EVENTS: > + t->val.max_events = val; > + break; > + case EVSEL__CONFIG_TERM_PERCORE: > + t->val.percore = val; > + break; > + case EVSEL__CONFIG_TERM_AUX_OUTPUT: > + t->val.aux_output = val; > + break; > + case EVSEL__CONFIG_TERM_AUX_SAMPLE_SIZE: > + t->val.aux_sample_size = val; > + break; > + case EVSEL__CONFIG_TERM_CALLGRAPH: > + case EVSEL__CONFIG_TERM_BRANCH: > + case EVSEL__CONFIG_TERM_DRV_CFG: > + case EVSEL__CONFIG_TERM_RATIO_TO_PREV: > + case EVSEL__CONFIG_TERM_AUX_ACTION: > + if (str) { > + t->val.str = strdup(str); > + if (!t->val.str) { > + zfree(&t); > + return NULL; > + } > + t->free_str = true; > + } > + break; > + default: > + t->val.val = val; > + break; > + } > + > list_add_tail(&t->list, head_terms); > - > return t; > } > > @@ -1142,7 +1196,7 @@ static int get_config_terms(const struct parse_events_terms *head_config, > struct evsel_config_term *new_term; > enum evsel_term_type new_type; > bool str_type = false; > - u64 val; > + u64 val = 0; > > switch (term->type_term) { > case PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD: > @@ -1234,20 +1288,15 @@ static int get_config_terms(const struct parse_events_terms *head_config, > continue; > } > > - new_term = add_config_term(new_type, head_terms, term->weak); > + /* > + * Note: Members evsel_config_term::val and > + * parse_events_term::val are unions and endianness needs > + * to be taken into account when changing such union members. > + */ > + new_term = add_config_term(new_type, head_terms, term->weak, > + str_type ? term->val.str : NULL, val); > if (!new_term) > return -ENOMEM; > - > - if (str_type) { > - new_term->val.str = strdup(term->val.str); > - if (!new_term->val.str) { > - zfree(&new_term); > - return -ENOMEM; > - } > - new_term->free_str = true; > - } else { > - new_term->val.val = val; > - } > } > return 0; > } > @@ -1277,10 +1326,9 @@ static int add_cfg_chg(const struct perf_pmu *pmu, > if (bits) { > struct evsel_config_term *new_term; > > - new_term = add_config_term(new_term_type, head_terms, false); > + new_term = add_config_term(new_term_type, head_terms, false, NULL, bits); > if (!new_term) > return -ENOMEM; > - new_term->val.cfg_chg = bits; > } > > return 0; Reviewed-by: James Clark