From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbdBJNsv (ORCPT ); Fri, 10 Feb 2017 08:48:51 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:28448 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdBJNst (ORCPT ); Fri, 10 Feb 2017 08:48:49 -0500 X-AuditID: cbfec7f2-f790f6d000002555-fb-589dc456026f Subject: Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface To: Joerg Roedel , Will Deacon , Robin Murphy , Lorenzo Pieralisi , Alex Williamson , David Woodhouse Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Marek Szyprowski Message-id: <9a1997dd-5835-cb9a-6478-7fb276151e52@samsung.com> Date: Fri, 10 Feb 2017 14:46:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-version: 1.0 In-reply-to: <1486639981-32368-11-git-send-email-joro@8bytes.org> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEKsWRmVeSWpSXmKPExsWy7djPc7phR+ZGGEw5qWXx7X8Pm8XElZOZ LRbst7bonL2B3WLyqblMFpseX2O1uLxrDpvFjPP7mCze/H7BbnHwwxNWi5cfT7A4cHs8OTiP yWPNvDWMHptXaHlsXlLvMfnGckaP9/uusnlsPl3t8XmTXABHFJdNSmpOZllqkb5dAlfGxc4L bAXv+CoW/n7F0sA4iaeLkZNDQsBE4uSJeSwQtpjEhXvr2boYuTiEBJYySuy88JcJwvnMKHHq /Q0WmI7Di+4wQiSWMUr8unOXFcJ5zigx99M+ZpAqYYEwiY5TZ8DaRQS+MErc2ncCzGEWWM8o cWl2PxtIFZuAoUTX2y4wm1fATuLs5u9g3SwCqhKvO86A2aICMRK9m6YxQ9QISvyYfA/sDk4B R4mH65sYQWxmASuJZ/9aWSFseYnNa94ygyyTELjFLnF810ygBRxAjqzEpgPMED+4SPRe+8IK YQtLvDq+hR3ClpG4PLkb6s9+RommVm0IewajxLm3vBC2tcTh4xehdvFJTNo2nRliPK9ER5sQ RImHxKW9r6BGOko8nn+BGRJCpxglpr/YwjKBUX4WkndmIXlhFpIXFjAyr2IUSS0tzk1PLTbW K07MLS7NS9dLzs/dxAhMSaf/Hf+0g/HrCatDjAIcjEo8vC9q5kQIsSaWFVfmHmKU4GBWEuGd cGhuhBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHePQuuhAsJpCeWpGanphakFsFkmTg4pRoYZ5yr vOrz7RD3kbDenY5ZK7XOXlVr57wuXLPwOOeC/SZJLCsc+g1Tj63sjXlneaL4tleP7V7blX7f OjgCPd1X6H15zWzE5qD08Mud8zJpGlNWrDyztbCjt/So2LYZvOcMfMW6dGLf2uvn5Lo7BpY4 5fGc8fJdGf5FMawmo/OwhkujbqDaBBYlluKMREMt5qLiRACW26meRQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t/xa7oRR+ZGGNx4w2Px7X8Pm8XElZOZ LRbst7bonL2B3WLyqblMFpseX2O1uLxrDpvFjPP7mCze/H7BbnHwwxNWi5cfT7A4cHs8OTiP yWPNvDWMHptXaHlsXlLvMfnGckaP9/uusnlsPl3t8XmTXABHlJtNRmpiSmqRQmpecn5KZl66 rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyLnZeYCt4x1ex8Pcr lgbGSTxdjJwcEgImEocX3WGEsMUkLtxbz9bFyMUhJLCEUeLy9wvMIAkhgeeMEh/XJoHYwgJh Eh2nzjCBFIkIfGOUmHj2HTtExylGiWOX/rGAOMwC6xkl+m7+YAdpYRMwlOh628UGYvMK2Emc 3fwdbCyLgKrE644zYLaoQIzE3v77TBA1ghI/Jt9jAbE5BRwlHq5vAruPWcBM4svLw6wQtrzE 5jVvmScwCsxC0jILSdksJGULGJlXMYqklhbnpucWG+kVJ+YWl+al6yXn525iBMbntmM/t+xg 7HoXfIhRgINRiYd3QtWcCCHWxLLiytxDjBIczEoivBMOzY0Q4k1JrKxKLcqPLyrNSS0+xGgK 9MREZinR5Hxg6sgriTc0MTS3NDQytrAwNzJSEued+uFKuJBAemJJanZqakFqEUwfEwenVAOj oEaWnNeD8+n3VmnnnM57Irv/UMVqTolsibzaf2qx157JGa3U/2R9sdT1U6e67u60ij9b9Kds yL7S9fKPSoTDlFnyDJ9YL0uvdJk2I/wPw+eFqX6C6zXM1S9MbWz4cUvusMwMzZ166UzbP27s P62nfKfv8f37TEk+c1XSYtfpnryvdyY6P+yoEktxRqKhFnNRcSIASSxOe+UCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170210134702eucas1p29f8e08e7bc4cce122f53bc8131ea763c X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170209113308epcas2p2cd79f382b04635bc7e973a62c093d557 X-RootMTR: 20170209113308epcas2p2cd79f382b04635bc7e973a62c093d557 References: <1486639981-32368-1-git-send-email-joro@8bytes.org> <1486639981-32368-11-git-send-email-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 2017-02-09 12:32, Joerg Roedel wrote: > From: Joerg Roedel > > Register Exynos IOMMUs to the IOMMU core and make them > visible in sysfs. This patch does not add the links between > IOMMUs and translated devices yet. > > Cc: Marek Szyprowski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Joerg Roedel Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski > --- > drivers/iommu/exynos-iommu.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index 57ba0d3..64325d8 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -276,6 +276,8 @@ struct sysmmu_drvdata { > struct list_head owner_node; /* node for owner controllers list */ > phys_addr_t pgtable; /* assigned page table structure */ > unsigned int version; /* our version */ > + > + struct iommu_device iommu; /* IOMMU core handle */ > }; > > static struct exynos_iommu_domain *to_exynos_domain(struct iommu_domain *dom) > @@ -611,6 +613,18 @@ static int __init exynos_sysmmu_probe(struct platform_device *pdev) > data->sysmmu = dev; > spin_lock_init(&data->lock); > > + ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, > + dev_name(data->sysmmu)); > + if (ret) > + return ret; > + > + iommu_device_set_ops(&data->iommu, &exynos_iommu_ops); > + iommu_device_set_fwnode(&data->iommu, &dev->of_node->fwnode); > + > + ret = iommu_device_register(&data->iommu); > + if (ret) > + return ret; > + > platform_set_drvdata(pdev, data); > > __sysmmu_get_version(data); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland