From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bibo Mao <maobibo@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Marc Zyngier <maz@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Jianmin Lv <lvjianmin@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v3 1/2] irqchip/loongson-eiointc: Fix return value checking of eiointc_index
Date: Tue, 11 Jul 2023 15:18:00 +0200 [thread overview]
Message-ID: <9a20851f-7981-bf31-eed1-7dd77528ca02@linaro.org> (raw)
In-Reply-To: <20230711120807.1805186-2-maobibo@loongson.cn>
On 11/7/23 14:08, Bibo Mao wrote:
> Return value of function eiointc_index is int, however it is converted
> into uint32_t and then compared smaller than zero. This causes logic
> problem. There is eioint initialization problem on qemu virt-machine
> where there is only one eioint node and more than 4 vcpus. Nodemap of
> eioint is 1, and external device intr can only be routed to vcpu 0-3, the
> other vcpus can not response any external device interrupts and only local
> processor interrupts like ipi/timer can work.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
> drivers/irqchip/irq-loongson-eiointc.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Fixes: dd281e1a1a93 ("irqchip: Add Loongson Extended I/O interrupt
controller support")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-11 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 12:08 [PATCH v3 0/2] irqchip/loongson-eiointc: Add simple irq routing method Bibo Mao
2023-07-11 12:08 ` [PATCH v3 1/2] irqchip/loongson-eiointc: Fix return value checking of eiointc_index Bibo Mao
2023-07-11 13:18 ` Philippe Mathieu-Daudé [this message]
2023-07-11 15:06 ` Huacai Chen
2023-07-12 1:03 ` bibo mao
2023-07-12 8:56 ` Marc Zyngier
2023-07-12 9:14 ` bibo mao
2023-07-11 12:08 ` [PATCH v3 2/2] irqchip/loongson-eiointc: Simplify irq routing on some platforms Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a20851f-7981-bf31-eed1-7dd77528ca02@linaro.org \
--to=philmd@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®