From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9ABEC6FA82 for ; Wed, 21 Sep 2022 15:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiIUPIG (ORCPT ); Wed, 21 Sep 2022 11:08:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbiIUPIE (ORCPT ); Wed, 21 Sep 2022 11:08:04 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7217E7755E for ; Wed, 21 Sep 2022 08:08:03 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id u18so9705848lfo.8 for ; Wed, 21 Sep 2022 08:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=RF9pE1XqBaCkFujXuhCj/YrM4VUzgwG2BT/TUrX/TQs=; b=Bgb+iEOe9wB7sYiTFOX2L4NoZHqArQD+KjhaktUTxRoqMOR7ETeLMVom22TQH6w/iB at55Y30/CDPtMsNUDzLUpckengtH+aKcMBIUymjHumbY5Wyqaq4CDTJ6UyZugqvxcnj/ NroVkcIrCvjn0eqE1R2xRIBlHp3dwf2WitEcDT1INMmzOnM6rAr77ER65QARn2u/0B/N PGDyD5ShJI9cTZMDm5w8mwaxoJgTZoCC7imKOxKrPgNNIvHPHUPEBQ4ow1gubY17I5P9 7uwYXQjX/eVZaYXKQ9804Jk266dh3Pibzjpdv7j4CZvS+IQmIacT3wih3O3X3YGtqpmp Tujg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=RF9pE1XqBaCkFujXuhCj/YrM4VUzgwG2BT/TUrX/TQs=; b=pDuLtp2uGkQ47KG7tUqHwb/V3lExtJeqQgOXC+iIIIvoPZ6jYnxwtOTOLwYkXsMqqD kxWUKrOHjhOPstvAiIc+WYWr41RFYPibvFx9Y6vSWAX3q8A7xv1LLdUIZgeCltPxlKB3 /98bEZ9uWwDniArbv7/5vcjZFzNnXn8TvfrWFXKuNlpncp7kCiHZH0b+auu3pNYBlbCG b3LVNl21Z1GjhJKwt721QRu6MqCiB1k4ImhfTwM1Gb0bOlzYGN2Zu21E2laasnYGrDY8 IFAoEiXmLMXdtxDpYK1/LTrGAqYb4HBnPDKXbqIGMDMGIFC6A0QWij6rQvOK7qluw+Jk OK2g== X-Gm-Message-State: ACrzQf3xny/dibmE54TIIOWfJPDtemu412dpx5i7weOHupaSLXVxlXid ol7/4930+v6QyBN5HONCNKLxeg== X-Google-Smtp-Source: AMsMyM6LiMMw9ZyS7tgrWaPytuR+QBRjPIZREoDo1FdiuatxHS0wsN9I/0scWOUEj/XR3+sFYsn3pA== X-Received: by 2002:ac2:52b1:0:b0:499:f7ac:14da with SMTP id r17-20020ac252b1000000b00499f7ac14damr11247218lfm.597.1663772881791; Wed, 21 Sep 2022 08:08:01 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id l10-20020a056512110a00b0049f9c732858sm462533lfg.254.2022.09.21.08.08.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 08:08:01 -0700 (PDT) Message-ID: <9a210b04-2ff2-df98-ad1a-89e9d8b0f686@linaro.org> Date: Wed, 21 Sep 2022 17:08:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable Content-Language: en-US From: Krzysztof Kozlowski To: Pierre-Louis Bossart , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20220921145354.1683791-1-krzysztof.kozlowski@linaro.org> <20916c9d-3598-7c40-ee77-1148c3d2e4b1@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/09/2022 17:06, Krzysztof Kozlowski wrote: > On 21/09/2022 17:05, Pierre-Louis Bossart wrote: >>> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c >>> index 06c6adbe5920..d2548fdf9ae5 100644 >>> --- a/sound/soc/codecs/wcd9335.c >>> +++ b/sound/soc/codecs/wcd9335.c >>> @@ -1972,8 +1972,8 @@ static int wcd9335_trigger(struct snd_pcm_substream *substream, int cmd, >>> case SNDRV_PCM_TRIGGER_STOP: >>> case SNDRV_PCM_TRIGGER_SUSPEND: >>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH: >>> - slim_stream_unprepare(dai_data->sruntime); >>> slim_stream_disable(dai_data->sruntime); >>> + slim_stream_unprepare(dai_data->sruntime); >> >> This looks logical but different from what the kernel doc says: >> >> /** >> * slim_stream_disable() - Disable a SLIMbus Stream >> * >> * @stream: instance of slim stream runtime to disable >> * >> * This API will disable all the ports and channels associated with >> * SLIMbus stream >> * >> * Return: zero on success and error code on failure. From ASoC DPCM >> framework, >> * this state is linked to trigger() pause operation. >> */ >> >> /** >> * slim_stream_unprepare() - Un-prepare a SLIMbus Stream >> * >> * @stream: instance of slim stream runtime to unprepare >> * >> * This API will un allocate all the ports and channels associated with >> * SLIMbus stream > > You mean this piece of doc? Indeed looks inaccurate. I'll update it. Wait, no, this is correct. Please point to what is wrong in kernel doc. I don't see it. :( Best regards, Krzysztof