From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B346C04AB6 for ; Tue, 28 May 2019 13:00:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33F222081C for ; Tue, 28 May 2019 13:00:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="Gcq2zKVu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727348AbfE1NAU (ORCPT ); Tue, 28 May 2019 09:00:20 -0400 Received: from node.akkea.ca ([192.155.83.177]:43840 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726870AbfE1NAU (ORCPT ); Tue, 28 May 2019 09:00:20 -0400 Received: by node.akkea.ca (Postfix, from userid 33) id C5BEC4E204B; Tue, 28 May 2019 13:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1559048419; bh=DuNG9eraJBekzRo7JMy/lt3azKRg+Ejt3Pynd/LUpQw=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=Gcq2zKVu0wYuEKx1clJT+CFI/Qm8Qg193Gq70Ah2BlMkn2oz/I6TTnc0xhDdkNjT2 oVS0ni69EfFkHZcePiIwstfo+zNZOlrY23KjNmj0tM5GctNlBJKiLCFEZVHRwwS7pb 2Bh+KPihajSNbxME+mHygXhqiDjAT7m7klszc4Sk= To: Lucas Stach Subject: Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 28 May 2019 06:00:19 -0700 From: Angus Ainslie Cc: angus.ainslie@puri.sm, Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Abel Vesa , Andrey Smirnov , Carlo Caione , =?UTF-8?Q?Guido_G=C3=BCnther?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <1559047905.4039.15.camel@pengutronix.de> References: <20190528124406.29730-1-angus@akkea.ca> <1559047905.4039.15.camel@pengutronix.de> Message-ID: <9a2361a08a0b8a1be1e2f5921026661f@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lucas, On 2019-05-28 05:51, Lucas Stach wrote: > Hi Angus, > > Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie > (Purism): >> Add the snvs power key. >> >> > Signed-off-by: Angus Ainslie (Purism) >> --- >>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++ >>  1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> index 45d10d8efd14..5f93fd9662ae 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> @@ -8,6 +8,7 @@ >>  #include >>  #include >>  #include >> +#include "dt-bindings/input/input.h" >>  #include >>  #include >>  #include "imx8mq-pinfunc.h" >> @@ -463,6 +464,14 @@ >> >   interrupts = , >> >   ; >> >   }; >> + >> > + snvs_pwrkey: snvs-powerkey { >> > + compatible = "fsl,sec-v4.0-pwrkey"; >> > + regmap = <&snvs>; >> > + interrupts = ; >> > + linux,keycode = ; >> + wakeup-source; > > Not all i.MX8MQ systems will have this functionality wired up at the > board level, so this node needs to be disabled by default. The existing > i.MX6 and i.MX7 DTs seem to get this wrong. > Ok I'll fix that for the next rev. Thanks Angus > Regards, > Lucas > >> + }; >> >   }; >>   >> > >   clk: clock-controller@30380000 {