From: Logan Gunthorpe <logang@deltatee.com>
To: Allen Hubbe <Allen.Hubbe@dell.com>,
linux-ntb@googlegroups.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "'Jon Mason'" <jdmason@kudzu.us>,
"'Dave Jiang'" <dave.jiang@intel.com>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Kurt Schwemmer'" <kurt.schwemmer@microsemi.com>,
"'Stephen Bates'" <sbates@raithlin.com>,
"'Serge Semin'" <fancer.lancer@gmail.com>
Subject: Re: [PATCH 12/16] switchtec_ntb: add link management
Date: Thu, 29 Jun 2017 12:37:46 -0600 [thread overview]
Message-ID: <9a280b29-4e1b-cf4a-54c2-25a522834879@deltatee.com> (raw)
In-Reply-To: <000201d2f103$2f3d2d20$8db78760$@dell.com>
On 6/29/2017 12:11 PM, Allen Hubbe wrote:
> Should we only set self_partition? I think each peer should be able to set preferred speed, and negotiate down. As written here, the last peer to set the speed overrides the setting on the peer, and even that is not atomic if they race.
This function isn't actually setting the link speed. (Though I can
understand the confusion from the name.) It's just reporting the slowest
speed on the link between the peers for the link_is_up function. (Each
port will have negotiated it's own speed).
I don't think switchtec has the ability to actually change the port
speed or width. (Seeing they are negotiated on boot).
Logan
next prev parent reply other threads:[~2017-06-29 18:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 3:26 [PATCH 00/16] Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 01/16] switchtec: move structure definitions into a common header Logan Gunthorpe
2017-07-05 19:37 ` Bjorn Helgaas
2017-06-29 3:26 ` [PATCH 02/16] switchtec: export class symbol for use in upper layer driver Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 03/16] switchtec: add ntb hardware register definitions Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 04/16] switchtec: add link event notifier callback Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 05/16] ntb: ensure ntb_mw_get_align is only called when the link is up Logan Gunthorpe
2017-06-29 18:11 ` Allen Hubbe
2017-06-29 3:26 ` [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align Logan Gunthorpe
2017-06-29 18:11 ` Allen Hubbe
2017-06-29 19:00 ` Logan Gunthorpe
2017-06-29 20:13 ` Allen Hubbe
2017-06-29 20:17 ` Logan Gunthorpe
2017-06-29 21:27 ` Hubbe, Allen
2017-06-29 21:35 ` Allen Hubbe
2017-06-29 22:14 ` Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 07/16] ntb: ntb_test: ensure the link is up before trying to configure the mws Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 08/16] switchtec_ntb: introduce initial ntb driver Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 09/16] switchtec_ntb: initialize hardware for memory windows Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 10/16] switchtec_ntb: initialize hardware for doorbells and messages Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 11/16] switchtec_ntb: add skeleton ntb driver Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 12/16] switchtec_ntb: add link management Logan Gunthorpe
2017-06-29 18:11 ` Allen Hubbe
2017-06-29 18:37 ` Logan Gunthorpe [this message]
2017-06-29 3:26 ` [PATCH 13/16] switchtec_ntb: implement doorbell registers Logan Gunthorpe
2017-07-05 19:42 ` Bjorn Helgaas
2017-06-29 3:26 ` [PATCH 14/16] switchtec_ntb: implement scratchpad registers Logan Gunthorpe
2017-06-29 18:11 ` Allen Hubbe
2017-06-29 18:33 ` Logan Gunthorpe
2017-06-29 3:26 ` [PATCH 15/16] switchtec_ntb: add memory window support Logan Gunthorpe
2017-07-05 19:46 ` Bjorn Helgaas
2017-06-29 3:26 ` [PATCH 16/16] switchtec_ntb: update switchtec documentation with notes for ntb Logan Gunthorpe
2017-06-29 15:15 ` [PATCH 00/16] Greg Kroah-Hartman
2017-06-29 15:37 ` Logan Gunthorpe
2017-07-05 19:47 ` Bjorn Helgaas
2017-07-05 19:50 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a280b29-4e1b-cf4a-54c2-25a522834879@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@dell.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®