From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] memory: tegra: Check whether reset is already asserted
Date: Sat, 23 Jan 2021 17:04:06 +0300 [thread overview]
Message-ID: <9a28c66a-8fa5-3c9b-3301-947341879525@gmail.com> (raw)
In-Reply-To: <20210122231950.znm7s3zukn63q46m@kozik-lap>
23.01.2021 02:19, Krzysztof Kozlowski пишет:
> On Sat, Jan 23, 2021 at 12:58:12AM +0300, Dmitry Osipenko wrote:
>> 23.01.2021 00:40, Krzysztof Kozlowski пишет:
>>> On Wed, Jan 20, 2021 at 02:52:10AM +0300, Dmitry Osipenko wrote:
>>>> Check whether memory client reset is already asserted in order to prevent
>>>> DMA-flush error on trying to re-assert an already asserted reset.
>>>>
>>>> This becomes a problem once PMC GENPD is enabled to use memory resets
>>>> since GENPD will get a error and fail to toggle power domain. PMC GENPDs
>>>> can't be toggled safely without holding memory reset on Tegra and we're
>>>> about to fix this.
>>>>
>>>> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
>>>> Tested-by: Dmitry Osipenko <digetx@gmail.com> # A500 T20 and Nexus7 T30
>>>
>>> Don't add your own Tested-by. Author has to test it. However this is a
>>> v1 and already three other people added tests. Where are the emails?
>>
>> The test results were given on #tegra irc.
>>
>> Author doesn't have to test, from time to time I'm helping people who
>> can't make a patch with fixing obvious bugs for the h/w that I don't
>> have access to.
>
> By default, author's patches are assumed to be tested, otherwise we
> would be putting own Tested-by in most of the cases (ideally: in all).
> Just because you do not see author's Tested-by everywhere it does not
> mean that author did not test it...
>
> Testing is also a requirement:
> https://elixir.bootlin.com/linux/latest/source/Documentation/process/5.Posting.rst#L35
>
> Therefore if your non-trivial patches are not tested, please also
> mention it with RFT or after '---'.
>
>>
>> Anyways, I'll make v2 with myself removed if you prefer that, thanks.
>
> I applied it without your tested-by. If the tested platform is anyhow
> relevant, just mention it in the commit msg.
Alright, thank you. In this particular case the platform should be
irrelevant.
prev parent reply other threads:[~2021-01-23 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 23:52 Dmitry Osipenko
2021-01-22 21:40 ` Krzysztof Kozlowski
2021-01-22 21:58 ` Dmitry Osipenko
2021-01-22 23:19 ` Krzysztof Kozlowski
2021-01-23 14:04 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a28c66a-8fa5-3c9b-3301-947341879525@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®