From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Michał Grzelak" <mig@semihalf.com>, devicetree@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch,
chris.packham@alliedtelesis.co.nz, netdev@vger.kernel.org,
upstream@semihalf.com, linux-kernel@vger.kernel.org
Subject: Re: [net PATCH 1/2] dt-bindings: net: marvell,orion-mdio: Fix error
Date: Tue, 27 Dec 2022 09:06:58 +0100 [thread overview]
Message-ID: <9a2ae843-1cc8-b3c7-1d63-da56547f81c8@linaro.org> (raw)
In-Reply-To: <20221227010523.59328-2-mig@semihalf.com>
On 27/12/2022 02:05, Michał Grzelak wrote:
> Fix 'unevaluated properties error' during 'make dtbs_check' appearing on
> arm device trees by defining generic 'ethernet-phy' subnode in
> marvell,orion-mdio.yaml.
Instead of long test just paste a bit of warning message. Much easier to
read.
>
> Fixes: 0781434af811f ("dt-bindings: net: orion-mdio: Convert to JSON
> schema")
Don't wrap tags.
> Signed-off-by: Michał Grzelak <mig@semihalf.com>
> ---
> Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> index d2906b4a0f59..2b2b3f8709fc 100644
> --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> @@ -35,6 +35,10 @@ properties:
> minItems: 1
> maxItems: 4
>
> +patternProperties:
> + '^ethernet-phy':
ethernet-phy@ is already accepted via mdio, so this looks wrong. You
need to rather fix the DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-27 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 1:05 [net PATCH 0/2] Orion MDIO DT binding fixes Michał Grzelak
2022-12-27 1:05 ` [net PATCH 1/2] dt-bindings: net: marvell,orion-mdio: Fix error Michał Grzelak
2022-12-27 8:06 ` Krzysztof Kozlowski [this message]
2022-12-27 1:05 ` [net PATCH 2/2] dt-bindings: net: marvell,orion-mdio: Fix examples Michał Grzelak
2022-12-27 8:10 ` Krzysztof Kozlowski
2022-12-28 1:54 ` [PATCH v2] " Michał Grzelak
2022-12-29 8:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a2ae843-1cc8-b3c7-1d63-da56547f81c8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mig@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®