From: Dmitry Osipenko <digetx@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Cc: lukasz.luba@arm.com, enric.balletbo@collabora.com,
hl@rock-chips.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, abel.vesa@nxp.com, k.konieczny@samsung.com,
b.zolnierkie@samsung.com, chanwoo@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes
Date: Sun, 25 Oct 2020 19:31:09 +0300 [thread overview]
Message-ID: <9a2c99d1-ef65-4d89-3740-90a3b60d4cd5@gmail.com> (raw)
In-Reply-To: <20201023102632.740-3-cw00.choi@samsung.com>
23.10.2020 13:26, Chanwoo Choi пишет:
> @@ -1401,8 +1423,13 @@ static ssize_t governor_store(struct device *dev, struct device_attribute *attr,
> "%s: reverting to Governor %s failed (%d)\n",
> __func__, df->governor_name, ret);
> df->governor = NULL;
> + goto out;
> }
...
> + create_sysfs_files(df, df->governor);
> + goto out;
These two lines could be removed.
> }
> + create_sysfs_files(df, df->governor);
> +
> out:
> mutex_unlock(&devfreq_list_lock);
Otherwise looks good to me.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2020-10-25 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201023101246epcas1p126bb1157eb75f972786758ef1e2f6e0c@epcas1p1.samsung.com>
2020-10-23 10:26 ` [PATCH v5 0/2] PM / devfreq: Add governor feature and attribute flag Chanwoo Choi
[not found] ` <CGME20201023101246epcas1p423f0444201300830fd63f33748dd8952@epcas1p4.samsung.com>
2020-10-23 10:26 ` [PATCH v5 1/2] PM / devfreq: Add governor feature flag Chanwoo Choi
2020-10-25 16:29 ` Dmitry Osipenko
[not found] ` <CGME20201023101247epcas1p14b14dc1be24842daac1dc7bd229d4570@epcas1p1.samsung.com>
2020-10-23 10:26 ` [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes Chanwoo Choi
2020-10-25 16:30 ` Dmitry Osipenko
2020-10-26 2:02 ` Chanwoo Choi
2020-10-25 16:31 ` Dmitry Osipenko [this message]
2020-10-26 2:03 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a2c99d1-ef65-4d89-3740-90a3b60d4cd5@gmail.com \
--to=digetx@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=b.zolnierkie@samsung.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=enric.balletbo@collabora.com \
--cc=hl@rock-chips.com \
--cc=jonathanh@nvidia.com \
--cc=k.konieczny@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome