From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58032C433E0 for ; Wed, 3 Jun 2020 15:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BE51206E6 for ; Wed, 3 Jun 2020 15:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbgFCPwV (ORCPT ); Wed, 3 Jun 2020 11:52:21 -0400 Received: from mga07.intel.com ([134.134.136.100]:9279 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbgFCPwV (ORCPT ); Wed, 3 Jun 2020 11:52:21 -0400 IronPort-SDR: 1eqTjdcysrWm9wotf83b3+y1gdLEj1FknXqml8D7n057aQs6Ck30MfB45cWkHZLsRbspdXkDC7 kg9quK8bDq7w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 08:52:20 -0700 IronPort-SDR: jRXoTz980AKMV6rZUN56Oz6RGQKQfNmgX8nWPP7KyrxBGSsusQF7pp5A1cMBRTmga73IkCknDi diHoG2OZI5VA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,468,1583222400"; d="scan'208";a="378144617" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 03 Jun 2020 08:52:20 -0700 Received: from [10.249.225.188] (abudanko-mobl.ccr.corp.intel.com [10.249.225.188]) by linux.intel.com (Postfix) with ESMTP id 04B9D5800E3; Wed, 3 Jun 2020 08:52:17 -0700 (PDT) Subject: Re: [PATCH v4 10/10] perf record: introduce --ctl-fd[-ack] options To: Adrian Hunter , Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Andi Kleen , linux-kernel References: <653fe5f3-c986-a841-1ed8-0a7d2fa24c00@linux.intel.com> <17506256-ef3d-e3a2-a655-a9059b652785@linux.intel.com> <3efb178e-19b9-2fca-e1c8-9dcfd4a3ac2c@intel.com> From: Alexey Budankov Organization: Intel Corp. Message-ID: <9a318e1c-06a0-5671-b4d3-10e3cd2d1525@linux.intel.com> Date: Wed, 3 Jun 2020 18:52:16 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <3efb178e-19b9-2fca-e1c8-9dcfd4a3ac2c@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.06.2020 18:44, Adrian Hunter wrote: > On 3/06/20 3:52 pm, Alexey Budankov wrote: >> >> On 03.06.2020 15:05, Adrian Hunter wrote: >>> On 25/05/20 5:23 pm, Alexey Budankov wrote: >>>> >>>> Introduce --ctl-fd[-ack] options to pass open file descriptors numbers >>>> from command line. Extend perf-record.txt file with --ctl-fd[-ack] >>>> options description. Document possible usage model introduced by >>>> --ctl-fd[-ack] options by providing example bash shell script. >>>> >>>> Signed-off-by: Alexey Budankov >>>> --- >>>> tools/perf/Documentation/perf-record.txt | 39 ++++++++++++++++++++++++ >>>> tools/perf/builtin-record.c | 10 ++++++ >>>> tools/perf/util/record.h | 2 ++ >>>> 3 files changed, 51 insertions(+) >>>> >>>> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt >>>> index c2c4ce7ccee2..5c012cfe68a4 100644 >>>> --- a/tools/perf/Documentation/perf-record.txt >>>> +++ b/tools/perf/Documentation/perf-record.txt >>>> @@ -614,6 +614,45 @@ appended unit character - B/K/M/G >>>> The number of threads to run when synthesizing events for existing processes. >>>> By default, the number of threads equals 1. >>>> >>>> +--ctl-fd:: >>>> +--ctl-fd-ack:: >>>> +Listen on ctl-fd descriptor for command to control measurement ('enable': enable events, >>>> +'disable': disable events. Optionally send control command completion ('ack') to fd-ack >>>> +descriptor to synchronize with the controlling process. >>> >>> You should also explain the use of --delay=-1 here. >> >> Well, possibly like this: >> >> "Listen on ctl-fd descriptor for command to control measurement ('enable': enable events, >> 'disable': disable events). Measurements can be started paused using --delay=-1 option. > > Instead of: > > "Measurements can be started paused using --delay=-1 option." > > perhaps: > > "To start with events disabled, the --delay=-1 option can be used." Exactly. In v7.