From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org,
deller@gmx.de, geert+renesas@glider.be, lee@kernel.org,
jingoohan1@gmail.com, dan.carpenter@linaro.org,
michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org,
linux-omap@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device
Date: Tue, 13 Jun 2023 12:47:48 +0200 [thread overview]
Message-ID: <9a390f13-4ad3-cddc-64f7-8a1737965242@suse.de> (raw)
In-Reply-To: <20230613103730.GA169438@aspen.lan>
[-- Attachment #1.1: Type: text/plain, Size: 1753 bytes --]
Hi
Am 13.06.23 um 12:37 schrieb Daniel Thompson:
> On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote:
>> Struct bd6107_platform_data refers to a platform device within
>> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
>> compares it against the fbdev device in struct fb_info.dev, which
>> is different. Fix the test by comparing to struct fb_info.device.
>>
>> Fixes a bug in the backlight driver and prepares fbdev for making
>> struct fb_info.dev optional.
>>
>> v2:
>> * move renames into separate patch (Javier, Sam, Michael)
>>
>> Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Cc: Lee Jones <lee@kernel.org>
>> Cc: Daniel Thompson <daniel.thompson@linaro.org>
>> Cc: Jingoo Han <jingoohan1@gmail.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: <stable@vger.kernel.org> # v3.12+
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks for going through the backlight patches.
>
>
> Daniel.
>
> PS Please don't treat this as an Acked-by, if you want to land this
> patchset via a single tree please coordinate with Lee Jones!
I'd like to merge them via drm-misc-next together with the rest of the
patchset. It's not DRM, but fbdev patches often go through that tree
quite often.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-06-13 10:47 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:07 [PATCH v2 00/38] fbdev: Make userspace interfaces optional Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device Thomas Zimmermann
2023-06-12 15:00 ` Dan Carpenter
2023-06-12 15:17 ` Ruhl, Michael J
2023-06-13 7:31 ` Thomas Zimmermann
2023-06-13 10:37 ` Daniel Thompson
2023-06-13 10:47 ` Thomas Zimmermann [this message]
2023-06-12 14:07 ` [PATCH v2 02/38] backlight/bd6107: Rename struct bd6107_platform_data.fbdev to 'dev' Thomas Zimmermann
2023-06-13 10:38 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 03/38] backlight/gpio_backlight: Compare against struct fb_info.device Thomas Zimmermann
2023-06-13 10:38 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 04/38] backlight/gpio_backlight: Rename field 'fbdev' to 'dev' Thomas Zimmermann
2023-06-13 10:39 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 05/38] backlight/lv5207lp: Compare against struct fb_info.device Thomas Zimmermann
2023-06-13 10:39 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 06/38] backlight/lv5207lp: Rename struct lv5207lp_platform_data.fbdev to 'dev' Thomas Zimmermann
2023-06-13 10:40 ` Daniel Thompson
2023-06-12 14:07 ` [PATCH v2 07/38] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 08/38] fbdev/atyfb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 09/38] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 10/38] fbdev/aty128fb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 11/38] fbdev/broadsheetfb: Call device_remove_file() with hardware device Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 12/38] fbdev/ep93xx-fb: Alloc DMA memory from " Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 13/38] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err() Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 14/38] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 15/38] fbdev/fsl-diu-fb: Output messages with fb_*() helpers Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 16/38] fbdev/mb862xxfb: Output messages with fb_dbg() Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 17/38] fbdev/metronomefb: Use hardware device for dev_err() Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 18/38] fbdev/nvidiafb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 19/38] fbdev/nvidiafb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 20/38] fbdev/pxa168fb: Do not assign to struct fb_info.dev Thomas Zimmermann
2023-06-12 14:07 ` [PATCH v2 21/38] fbdev/radeonfb: Reorder backlight and framebuffer cleanup Thomas Zimmermann
2023-06-12 15:51 ` Sam Ravnborg
2023-06-12 14:08 ` [PATCH v2 22/38] fbdev/radeonfb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 23/38] fbdev/rivafb: Reorder backlight and framebuffer init/cleanup Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 24/38] fbdev/rivafb: Use hardware device as backlight parent Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 25/38] fbdev/sh7760fb: Use fb_dbg() in sh7760fb_get_color_info() Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 26/38] fbdev/sh7760fb: Output messages with fb_dbg() Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 27/38] fbdev/sh7760fb: Alloc DMA memory from hardware device Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 28/38] fbdev/sh7760fb: Use hardware device with dev_() output during probe Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 29/38] fbdev/sm501fb: Output message with fb_err() Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 30/38] fbdev/smscufx: Detect registered fb_info from refcount Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 31/38] fbdev/tdfxfb: Set i2c adapter parent to hardware device Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 32/38] fbdev/core: Pass Linux device to pm_vt_switch_*() functions Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 33/38] fbdev/core: Move framebuffer and backlight helpers into separate files Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 34/38] fbdev/core: Add fb_device_{create,destroy}() Thomas Zimmermann
2023-06-12 15:43 ` Sam Ravnborg
2023-06-12 14:08 ` [PATCH v2 35/38] fbdev/core: Move procfs code to separate file Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 36/38] fbdev/core: Move file-I/O code into " Thomas Zimmermann
2023-06-13 9:17 ` Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 37/38] fbdev/core: Rework fb init code Thomas Zimmermann
2023-06-12 14:08 ` [PATCH v2 38/38] fbdev: Make support for userspace interfaces configurable Thomas Zimmermann
2023-06-13 10:43 ` Daniel Thompson
2023-06-12 15:56 ` [PATCH v2 00/38] fbdev: Make userspace interfaces optional Sam Ravnborg
2023-06-12 16:04 ` Javier Martinez Canillas
2023-06-13 10:41 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a390f13-4ad3-cddc-64f7-8a1737965242@suse.de \
--to=tzimmermann@suse.de \
--cc=dan.carpenter@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=javierm@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=michael.j.ruhl@intel.com \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®