From: Mario Limonciello <mario.limonciello@amd.com>
To: Arnd Bergmann <arnd@kernel.org>, Min Ma <min.ma@amd.com>,
Lizhi Hou <lizhi.hou@amd.com>, Oded Gabbay <ogabbay@kernel.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Narendra Gutta <VenkataNarendraKumar.Gutta@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] accel/amdxdna: include linux/slab.h
Date: Wed, 18 Dec 2024 08:30:08 -0600 [thread overview]
Message-ID: <9a3d1829-8d63-4f69-b34f-d5667bcf4826@amd.com> (raw)
In-Reply-To: <20241218085902.2684002-1-arnd@kernel.org>
On 12/18/2024 02:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver fails to build in random configurations:
>
> drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node':
> drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
> 121 | kfree(pt_node);
> | ^~~~~
> drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition':
> drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
> 153 | pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL);
>
> Add the missing include.
>
> Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This one is still needed, I had previously combined two missing includes
> in one patch
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Applied to drm-misc-next.
221e29e197981 accel/amdxdna: include linux/slab.h
> ---
> drivers/accel/amdxdna/aie2_solver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/aie2_solver.c b/drivers/accel/amdxdna/aie2_solver.c
> index 1939625d6027..2013d1f13aae 100644
> --- a/drivers/accel/amdxdna/aie2_solver.c
> +++ b/drivers/accel/amdxdna/aie2_solver.c
> @@ -8,6 +8,7 @@
> #include <drm/drm_print.h>
> #include <linux/bitops.h>
> #include <linux/bitmap.h>
> +#include <linux/slab.h>
>
> #include "aie2_solver.h"
>
prev parent reply other threads:[~2024-12-18 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 8:58 Arnd Bergmann
2024-12-18 14:30 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a3d1829-8d63-4f69-b34f-d5667bcf4826@amd.com \
--to=mario.limonciello@amd.com \
--cc=VenkataNarendraKumar.Gutta@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®