From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbdJDGVF (ORCPT ); Wed, 4 Oct 2017 02:21:05 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:61622 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdJDGVC (ORCPT ); Wed, 4 Oct 2017 02:21:02 -0400 Subject: Re: [PATCH 3/4] staging: bcm2835-camera: pr_err() strings should end with newlines To: Arvind Yadav , gregkh@linuxfoundation.org, jacobvonchorus@cwphoto.ca, mchehab@kernel.org, eric@anholt.net, f.fainelli@gmail.com, rjui@broadcom.com, Larry.Finger@lwfinger.net, pkshih@realtek.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <1507031006-16543-1-git-send-email-arvind.yadav.cs@gmail.com> <1507031006-16543-4-git-send-email-arvind.yadav.cs@gmail.com> From: Stefan Wahren Message-ID: <9a3f3098-4886-67a4-c728-2c5e450ecc5f@i2se.com> Date: Wed, 4 Oct 2017 08:20:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507031006-16543-4-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K0:rAjphjyvwFwvEY9venkbX/1PLNRzOMaGMTFfjdj1/ayXEFPXU5g 90DB/UhpTerGo5YJRzEAsJYSFCXr0cbavNm2AkmU6a+V9bJN5XB2A8v0m4tDIoOT0dSxC9L iRQMfCx0d6PhdTb70r1UrfLI/7uj0xtkV/cjo5MMk6kcDtYFWAZ+CTw5TOasWx+3Ve4KQQi hkZfsK3TfiEnK9aa7UXIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:13roewYfxSw=:SDEaN+z9u73hsGGIaomv1d gcOaFtIMPK3llfi5n97hINzEu2pPc3VLqN27PMqnaUWQUbGa9bbwxVYst1hF7yd2Gd/gcAP2l WbDlbqsTtfam+wfGqE0QrWLKC7+lGEydh9A9u9r6L4CTCFH3G3w6QVPVNMzx32b4GK7GzbC3p GOvqa3S/XZ79zMMi2Y+CbEplnJBpu9u3RzhTiynlV2a1ao8wPlaKnKERy4CclIvDQOwpuSQxi icVn7qZCupOyXJyvjWY2y6anQN4darEv0PUxu3Eog82+zgMttLBt0WmvEdwBGTNC7/q5ADdw9 g6enwTkiyrKCqx73jMR1Sh/IbE82csr+VOyonW83iyYz3sbXd6mse8VjnsaNfbXJlv//hWltf TOopB82rPES3EKeB7Y2H8EctbxQOEzTBd3PPfPe4sAv+iqd/wkJe5Nq3dexVQ2k5Gjob8bsCc y9y4Cntx+J87rxlxTM2d5LLHOJAwQe/C2ZEAx9NkozrwsMjiZ3PD/BeodVwIx5Ncvqr5mRnwh wfrZXDz+NmyRA3dQ9azIyMuXaTtjeqZZpVlUSeN7YehH3eTSQ9RVNddae1YYgHl7aQVb+ytNT uu4P1tS7yOc4yfrP51kYdBcUw6GXSggICtyhUdb4U521qL20kauZzRaNt8HXdBdpNi9Fp5x2U DL506JukiV/aU8WQC/RxqJ5NtnkLjPtZQZ+tEB0+QHBUMPk84sqNQuvdsu3AmcOJWoro3drBo wfTAK1lWi5qNtbzryMJFDvhI2IaSYvlcIleZ27j2ZhDUUorSe8TG4ZOwAZg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 03.10.2017 um 13:43 schrieb Arvind Yadav: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav Acked-by: Stefan Wahren > --- > drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c > index 4360db6..6ea7fb0 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c > @@ -1963,7 +1963,7 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance) > > status = vchi_service_close(instance->handle); > if (status != 0) > - pr_err("mmal-vchiq: VCHIQ close failed"); > + pr_err("mmal-vchiq: VCHIQ close failed\n"); > > mutex_unlock(&instance->vchiq_mutex); >