From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Rob Herring <robh@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
Roger Quadros <rogerq@kernel.org>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
Date: Tue, 7 Dec 2021 17:27:22 +0100 [thread overview]
Message-ID: <9a412f16-9375-32ae-cbda-ae9f38332887@canonical.com> (raw)
In-Reply-To: <CAL_JsqKBE5p2hA0F4DqrzA1ERA484kzDsZP2u1nq79yTG2nM+A@mail.gmail.com>
On 07/12/2021 16:54, Rob Herring wrote:
> On Tue, Dec 7, 2021 at 3:12 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> On 06/12/2021 18:42, Rob Herring wrote:
>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>>> has a warning:
>>>
>>> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>>>
>>> The child node definition for GPMC is not a complete binding, so specifying
>>> 'unevaluatedProperties: false' for it is not correct and should be
>>> dropped.
>>>
>>> Fixup the unnecessary 'allOf' while we're here.
>>>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Cc: Roger Quadros <rogerq@kernel.org>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
>>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>
>> Looks good. Rob, do you want to take it via your tree or I should handle it?
>
> I'll take it given there's also the somewhat related "dt-bindings:
> mtd: ti,gpmc-nand: Add missing 'rb-gpios'"
Sure, then:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-12-07 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 17:42 Rob Herring
2021-12-07 8:37 ` Thierry Reding
2021-12-07 9:12 ` Krzysztof Kozlowski
2021-12-07 15:54 ` Rob Herring
2021-12-07 16:27 ` Krzysztof Kozlowski [this message]
2021-12-07 12:49 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a412f16-9375-32ae-cbda-ae9f38332887@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®