From: "Christian König" <christian.koenig@amd.com>
To: Philipp Stanner <phasta@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Simona Vetter <simona.vetter@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>,
Danilo Krummrich <dakr@kernel.org>, Gary Guo <gary@garyguo.net>,
Alice Ryhl <aliceryhl@google.com>,
Daniel Almeida <daniel.almeida@collabora.com>,
Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v4] dma-buf/dma-fence: Prevent misordering for error checks
Date: Fri, 20 Nov 2026 13:36:12 +0100 [thread overview]
Message-ID: <9a434a22-249b-4121-a390-95eaedb5ba6a@amd.com> (raw)
In-Reply-To: <20261120111615.2940647-2-phasta@kernel.org>
On 11/20/26 12:16, Philipp Stanner wrote:
> Many users of dma_fence do things like:
>
> // Thread A
> dma_fence_set_error(f, -EINVAL);
> dma_fence_signal(f); // <- test_and_set_bit() orders against the above.
>
> // Thread B
> if (dma_fence_is_signaled(f)) // <- Does test_bit(), no ordering.
> pr_info("err: %i\n", f->error); // <- Can be loaded first.
>
> There is no memory ordering between reading of the signaled-bit and
> reading of the error code. This can result in outdated, wrong error
> codes being evaluated by the user. That's a significant bug when we
> consider that fences' purpose is to propagate the state of jobs running
> on hardware.
>
> dma_fence_get_status() does take the fence lock, presumably to ensure
> ordering, but it is broken, too, because the read misordering can simply
> happen within the critical section.
>
> It's not entirely clear since when this bug exists, but at least since
> dma_fence_get_status() was added, which is why its birth commit is
> marked as the Fixes commit here.
>
> Ensure ordering for everyone evaluating the error code centrally by
> using test_bit_acquire() in dma_fence_test_signaled_flag().
>
> Cc: stable@vger.kernel.org
> Fixes: d6c99f4bf093 ("dma-fence: Wrap querying the fence->status")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> Changes in v4:
> - Keep the hint at the function being opportunistic. (Christian)
>
> Changes in v3:
> - Be more precise in code comments and commit message about how the
> ordering works. (Gary)
> - Update the function's documentation to inform about ordering
> semantics.
> ---
> include/linux/dma-fence.h | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index dd07d128adc3..64330bf52561 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -487,16 +487,23 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence);
> * with the fence in any way. The user must, therefore, ensure through other
> * means that fences get signaled eventually.
> *
> - * This function uses test_bit(), which is thread-safe. Naturally, this function
> - * should be used opportunistically; a fence could get signaled at any moment
> - * after the check is done.
> + * Naturally, this function should be used opportunistically; a fence could get
> + * signaled at any moment after the check is done.
> + *
> + * This function provides acquire ordering. This means that all stores
> + * preceding the signaling of a fence are visible in correct order to users of
> + * this function.
> *
> * Return: true if signaled, false otherwise.
> */
> static inline bool
> dma_fence_test_signaled_flag(struct dma_fence *fence)
> {
> - return test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
> + /*
> + * The release counterpart is the test_and_set_bit() in
> + * dma_fence_signal_timestamp_locked().
> + */
> + return test_bit_acquire(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags);
> }
>
> /**
next prev parent reply other threads:[~2026-11-20 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 11:16 Philipp Stanner
2026-11-20 12:36 ` Christian König [this message]
2026-11-20 13:13 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a434a22-249b-4121-a390-95eaedb5ba6a@amd.com \
--to=christian.koenig@amd.com \
--cc=aliceryhl@google.com \
--cc=chris@chris-wilson.co.uk \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=phasta@kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®