Re: [PATCH v17 08/10] coresight: Add CORESIGHT_DEVID2 to linux/coresight.h

[Suzuki K Poulose <suzuki.poulose@arm.com>]

On 13/11/2026 02:49, Songwei Chai wrote:
> CORESIGHT_DEVID2 lives at a fixed, architecturally-defined offset
> (0xfc0) within the generic CoreSight management register block,
> immediately preceding CORESIGHT_DEVID (0xfc8). Components outside
> drivers/hwtracing/coresight/ that follow the same register convention
> (e.g. the Qualcomm TGU, which uses it to detect its timer/counter
> capabilities) need to read it too.
> 
> Add it to the public include/linux/coresight.h so it can be shared
> outside of drivers/hwtracing/coresight/, matching CORESIGHT_LAR and
> CORESIGHT_DEVID already moved there.
> 
> Signed-off-by: Songwei Chai <songwei.chai@oss.qualcomm.com>
> ---
>   include/linux/coresight.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 5286b3606581..7ce0366c7c70 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -37,6 +37,7 @@
>   #define CORESIGHT_UNLOCK	0xc5acce55
>   #define CORESIGHT_LAR		0xfb0
>   #define CORESIGHT_DEVID		0xfc8
> +#define CORESIGHT_DEVID2	0xfc0
>   
>   static inline void CS_LOCK(void __iomem *addr)
>   {


Merge it with Patch 1 please.

Suzuki