From: Jens Axboe <axboe@kernel.dk>
To: yu kuai <yukuai3@huawei.com>,
ming.lei@redhat.com, martin.petersen@oracle.com,
wenwen@cs.uga.edu
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed
Date: Tue, 2 Jun 2020 16:44:57 -0600 [thread overview]
Message-ID: <9a4eb4b7-76f2-0b1c-c760-a09a76ee325a@kernel.dk> (raw)
In-Reply-To: <20200601123856.3895734-1-yukuai3@huawei.com>
On 6/1/20 6:38 AM, yu kuai wrote:
> commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a
> kree() for 'buf' if bio_integrity_add_page() return '0'. However, the
> object will be freed in bio_integrity_free() since 'bio->bi_opf' and
> 'bio->bi_integrity' was set previousy in bio_integrity_alloc().
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-06-02 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 12:38 yu kuai
2020-06-02 7:37 ` Ming Lei
2020-06-02 8:01 ` Bob Liu
2020-06-02 22:35 ` Martin K. Petersen
2020-06-02 22:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4eb4b7-76f2-0b1c-c760-a09a76ee325a@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=wenwen@cs.uga.edu \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®