From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai1@huaweicloud.com>, johannes.thumshirn@wdc.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH -next 1/2] block: fix that blk_time_get_ns() doesn't update time after schedule
Date: Thu, 11 Apr 2024 10:44:39 -0600 [thread overview]
Message-ID: <9a4f8738-6ad5-407e-a938-83395aa1df4f@kernel.dk> (raw)
In-Reply-To: <20240411032349.3051233-2-yukuai1@huaweicloud.com>
On 4/10/24 9:23 PM, Yu Kuai wrote:
> diff --git a/block/blk-core.c b/block/blk-core.c
> index a16b5abdbbf5..e317d7bc0696 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1195,6 +1195,7 @@ void __blk_flush_plug(struct blk_plug *plug, bool from_schedule)
> if (unlikely(!rq_list_empty(plug->cached_rq)))
> blk_mq_free_plug_rqs(plug);
>
> + plug->cur_ktime = 0;
> current->flags &= ~PF_BLOCK_TS;
> }
We can just use blk_plug_invalidate_ts() here, but not really important.
I think this one should go into 6.9, and patch 2 should go into 6.10,
however.
--
Jens Axboe
next prev parent reply other threads:[~2024-04-11 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 3:23 [PATCH -next 0/2] block: fix cached time in plug Yu Kuai
2024-04-11 3:23 ` [PATCH -next 1/2] block: fix that blk_time_get_ns() doesn't update time after schedule Yu Kuai
2024-04-11 16:44 ` Jens Axboe [this message]
2024-04-12 1:24 ` Yu Kuai
2024-04-12 14:33 ` Jens Axboe
2024-04-11 3:23 ` [PATCH -next 2/2] block: add plug while submitting IO Yu Kuai
2024-04-12 14:33 ` (subset) [PATCH -next 0/2] block: fix cached time in plug Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4f8738-6ad5-407e-a938-83395aa1df4f@kernel.dk \
--to=axboe@kernel.dk \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®