From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AF8C001DF for ; Fri, 20 Oct 2023 05:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346648AbjJTFla (ORCPT ); Fri, 20 Oct 2023 01:41:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233505AbjJTFl2 (ORCPT ); Fri, 20 Oct 2023 01:41:28 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51EAC1A6; Thu, 19 Oct 2023 22:41:26 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 433941F38C; Fri, 20 Oct 2023 05:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1697780483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qC1EtdiL0sWOeG47S5yhpa8vuKjnIigBgj1W4A3nuyE=; b=tryR/mSKMBjG7XlRO/HjlizgTYSK0eFn6i2PODMFwegv2RThJ858mBN8mKggBmkebRTdG0 M7gHH8ISFPLmt67XYpBM/7L9YrGDEWD8urTvrgM55M3mqAI9wIfi2JYeMyaDxbakEunfu8 I8UFDfBlduYxDue3+63ajsUrnYYv0t0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1697780483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qC1EtdiL0sWOeG47S5yhpa8vuKjnIigBgj1W4A3nuyE=; b=beh7P0tZIIwhrLrnpjy27hvv36M90OppuYB7IgsmOJS6BllqqpcqggLjsJMoIau97w92I3 i0D77SybuqCq8BCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12B231348D; Fri, 20 Oct 2023 05:41:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lHnWAwMTMmWYYQAAMHmgww (envelope-from ); Fri, 20 Oct 2023 05:41:23 +0000 Message-ID: <9a5a8167-488b-3819-8aa5-ddd5bd5bacc2@suse.cz> Date: Fri, 20 Oct 2023 07:41:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 6/6] mm: kmem: reimplement get_obj_cgroup_from_current() Content-Language: en-US To: Roman Gushchin , Andrew Morton Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Dennis Zhou , David Rientjes , Naresh Kamboju References: <20231019225346.1822282-1-roman.gushchin@linux.dev> <20231019225346.1822282-7-roman.gushchin@linux.dev> From: Vlastimil Babka In-Reply-To: <20231019225346.1822282-7-roman.gushchin@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-8.45 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-0.35)[76.41%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[11]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20/23 00:53, Roman Gushchin wrote: > Reimplement get_obj_cgroup_from_current() using current_obj_cgroup(). > get_obj_cgroup_from_current() and current_obj_cgroup() share 80% of > the code, so the new implementation is almost trivial. Great. > get_obj_cgroup_from_current() is a convenient function used by the > bpf subsystem, so there is no reason to get rid of it completely. > > Signed-off-by: Roman Gushchin (Cruise) Reviwed-by: Vlastimil Babka Thanks!