From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E0B8199949 for ; Sun, 29 Mar 2026 07:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774767718; cv=none; b=UdduMV/Z+gaLn94d/H+EMajcqzjRnU7rDhENNkr15ULCDFraPTRKhkTvY/eVc4262k/i20vt8Xs2/T51DNb9AK7ByyiLEX0mU5R0aj5y6NAJKGbVk4nasPjG6fazK/fQ0bVyv1PeR0yk5eZiufO1fc+DXAgk1jrtLdgaW9frX3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774767718; c=relaxed/simple; bh=JVxG6kU5+6Huy6Bg/7Kuod/+QecvvJh8wdFcacmL5ds=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LP7cnBlE5vzCLcRdrgdSaeymPIkkbqQVXK4ooMVwHexgbG6pcpW29loz8pI3TSIenx0Td1L7pXH+agUA68DOn1D1VKZvKSfD7zZ0FFfwqjClkGjY5MWGWnHMCMWSK3WBdD9ru5kRtdwOSXxYbab+dQZnXpJc7TbZlJSzwhm0ZXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wnARQt84; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wnARQt84" Message-ID: <9a5b0c6f-ea1a-48b4-b187-45bcfc9b9b4a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1774767715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9MRaUwf3lRRXxaUoLDqG17l+JMMaxT2+q85RQmmh2co=; b=wnARQt84QZRLkBBHOblPy2D5r/Ee9kHiDfvZG+CKcF/TSa7oVf7C+UYNdf3uxujKfu8tgg R2duFL2TSouRU0Gua8NAd5pwi4yq+pMr3JNiGXBp1z5EyT0I5/A8Tsyu9MuAv3ir9MMLmn mz1OYmh5q5582VWEs+AoHFGHL/vYQLw= Date: Sun, 29 Mar 2026 00:01:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 2/3] RDMA/rxe: add SENT/RCVD bytes To: zhenwei pi , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, "yanjun.zhu@linux.dev" Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org References: <20260329054156.125362-1-zhenwei.pi@linux.dev> <20260329054156.125362-3-zhenwei.pi@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20260329054156.125362-3-zhenwei.pi@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2026/3/28 22:41, zhenwei pi 写道: > There is a lack of sent/received counter in bytes. > Thanks a lot. Reviewed-by: Zhu Yanjun Zhu Yanjun > Signed-off-by: zhenwei pi > --- > drivers/infiniband/sw/rxe/rxe_hw_counters.c | 2 ++ > drivers/infiniband/sw/rxe/rxe_hw_counters.h | 2 ++ > drivers/infiniband/sw/rxe/rxe_net.c | 1 + > drivers/infiniband/sw/rxe/rxe_recv.c | 1 + > drivers/infiniband/sw/rxe/rxe_verbs.h | 6 ++++++ > 5 files changed, 12 insertions(+) > > diff --git a/drivers/infiniband/sw/rxe/rxe_hw_counters.c b/drivers/infiniband/sw/rxe/rxe_hw_counters.c > index 437917a7d8f2..17edaa9a9b9b 100644 > --- a/drivers/infiniband/sw/rxe/rxe_hw_counters.c > +++ b/drivers/infiniband/sw/rxe/rxe_hw_counters.c > @@ -22,6 +22,8 @@ static const struct rdma_stat_desc rxe_counter_descs[] = { > [RXE_CNT_LINK_DOWNED].name = "link_downed", > [RXE_CNT_RDMA_SEND].name = "rdma_sends", > [RXE_CNT_RDMA_RECV].name = "rdma_recvs", > + [RXE_CNT_SENT_BYTES].name = "sent_bytes", > + [RXE_CNT_RCVD_BYTES].name = "rcvd_bytes", > }; > > int rxe_ib_get_hw_stats(struct ib_device *ibdev, > diff --git a/drivers/infiniband/sw/rxe/rxe_hw_counters.h b/drivers/infiniband/sw/rxe/rxe_hw_counters.h > index 051f9e1c3852..01b355103cbc 100644 > --- a/drivers/infiniband/sw/rxe/rxe_hw_counters.h > +++ b/drivers/infiniband/sw/rxe/rxe_hw_counters.h > @@ -26,6 +26,8 @@ enum rxe_counters { > RXE_CNT_LINK_DOWNED, > RXE_CNT_RDMA_SEND, > RXE_CNT_RDMA_RECV, > + RXE_CNT_SENT_BYTES, > + RXE_CNT_RCVD_BYTES, > RXE_NUM_OF_COUNTERS > }; > > diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c > index 20338cb8e3c2..ec0ae7479fe7 100644 > --- a/drivers/infiniband/sw/rxe/rxe_net.c > +++ b/drivers/infiniband/sw/rxe/rxe_net.c > @@ -519,6 +519,7 @@ int rxe_xmit_packet(struct rxe_qp *qp, struct rxe_pkt_info *pkt, > } > > rxe_counter_inc(rxe, RXE_CNT_SENT_PKTS); > + rxe_counter_add(rxe, RXE_CNT_SENT_BYTES, skb->len); > goto done; > > drop: > diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c > index 5861e4244049..b5522017852d 100644 > --- a/drivers/infiniband/sw/rxe/rxe_recv.c > +++ b/drivers/infiniband/sw/rxe/rxe_recv.c > @@ -342,6 +342,7 @@ void rxe_rcv(struct sk_buff *skb) > goto drop; > > rxe_counter_inc(rxe, RXE_CNT_RCVD_PKTS); > + rxe_counter_add(rxe, RXE_CNT_RCVD_BYTES, skb->len); > > if (unlikely(bth_qpn(pkt) == IB_MULTICAST_QPN)) > rxe_rcv_mcast_pkt(rxe, skb); > diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h > index fb149f37e91d..2bcfb919a40b 100644 > --- a/drivers/infiniband/sw/rxe/rxe_verbs.h > +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h > @@ -460,6 +460,12 @@ static inline void rxe_counter_inc(struct rxe_dev *rxe, enum rxe_counters index) > atomic64_inc(&rxe->stats_counters[index]); > } > > +static inline void rxe_counter_add(struct rxe_dev *rxe, enum rxe_counters index, > + s64 val) > +{ > + atomic64_add(val, &rxe->stats_counters[index]); > +} > + > static inline struct rxe_dev *to_rdev(struct ib_device *dev) > { > return dev ? container_of(dev, struct rxe_dev, ib_dev) : NULL;