From: "H. Peter Anvin" <hpa@zytor.com>
To: David Keisar Schm <david.keisarschm@mail.huji.ac.il>
Cc: linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Jason@zx2c4.com, keescook@chromium.org,
aksecurity@gmail.com, ilay.bahat1@gmail.com
Subject: Re: [PATCH v4 3/3] x86 mm, x86 architecture (32-bit and 64-bit): arch/x86/mm/kaslr.c: Adds 64bits version of prandom_seed_state
Date: Tue, 17 Jan 2023 15:50:41 -0800 [thread overview]
Message-ID: <9a5b63ce-aeaa-77cf-0e36-53ee472a1656@zytor.com> (raw)
In-Reply-To: <CAD0z2U1Y1CR_erAj+akPbVF2jxicdQKQfqWPc69fwL-rvSu_fQ@mail.gmail.com>
On 1/17/23 13:16, David Keisar Schm wrote:
>
> Because (the way we understand this), Kees Cook prefers to keep the
> original API, so that a fixed seed can be injected at will (for
> debugging). Seehttps://lkml.org/lkml/2023/1/6/772
> <https://lkml.org/lkml/2023/1/6/772>
>
This bothers me, because with FG-KASLR is *exactly* when a bad PRNG will
shine through.
-hpa
prev parent reply other threads:[~2023-01-18 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 21:33 [PATCH v4 0/3] Secure prandom_u32 invocations david.keisarschm
2023-01-13 21:35 ` [PATCH v4 1/3] slab_allocator: mm/slab.c: Replace invocation of weak PRNG david.keisarschm
2023-01-13 21:37 ` [PATCH v4 2/3] slab_allocator: mm/slab_common.c: " david.keisarschm
2023-01-13 21:39 ` [PATCH v4 3/3] x86 mm, x86 architecture (32-bit and 64-bit): arch/x86/mm/kaslr.c: Adds 64bits version of prandom_seed_state david.keisarschm
2023-01-14 2:10 ` H. Peter Anvin
[not found] ` <CAD0z2U1Y1CR_erAj+akPbVF2jxicdQKQfqWPc69fwL-rvSu_fQ@mail.gmail.com>
2023-01-17 23:50 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5b63ce-aeaa-77cf-0e36-53ee472a1656@zytor.com \
--to=hpa@zytor.com \
--cc=Jason@zx2c4.com \
--cc=aksecurity@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david.keisarschm@mail.huji.ac.il \
--cc=ilay.bahat1@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®