From: Sinan Kaya <okaya@codeaurora.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Netdev <netdev@vger.kernel.org>,
timur@codeaurora.org, sulrich@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs
Date: Sat, 24 Mar 2018 00:02:24 -0400 [thread overview]
Message-ID: <9a5f49c8-ce50-a153-44e1-6f21f8d1f44b@codeaurora.org> (raw)
In-Reply-To: <CACKFLinCMQ6aFXJDcqkTGGuPSEWsPPB09sS=mJJgsCdm5mvjhA@mail.gmail.com>
On 3/23/2018 6:36 PM, Michael Chan wrote:
>> + mmiowb();
> Sorry for the late review. mmiowb() is not required here because we
> are in NAPI context, so only one CPU will be updating this doorbell.
>
> Other than that, it looks good.
>
OK, I'll fix this on the next version.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2018-03-24 4:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521843791-21201-1-git-send-email-okaya@codeaurora.org>
2018-03-23 22:23 ` [PATCH v6 1/6] net: qla3xxx: " Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 2/6] qlcnic: " Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 3/6] bnx2x: Replace doorbell barrier() with wmb() Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 4/6] bnx2x: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 5/6] net: qlge: " Sinan Kaya
2018-03-23 22:23 ` [PATCH v6 6/6] bnxt_en: " Sinan Kaya
2018-03-23 22:36 ` Michael Chan
2018-03-24 4:02 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5f49c8-ce50-a153-44e1-6f21f8d1f44b@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome