From: kaixuxia <xiakaixu1987@gmail.com>
To: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] btrfs: remove the useless value assignment in btrfs_defrag_file
Date: Tue, 17 Nov 2020 10:53:23 +0800 [thread overview]
Message-ID: <9a60330f-ae5e-ba78-ef34-69ab2b7ee0df@gmail.com> (raw)
In-Reply-To: <20201116151338.GI6756@twin.jikos.cz>
On 2020/11/16 23:13, David Sterba wrote:
> On Sat, Nov 14, 2020 at 05:06:21PM +0800, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> The variable ret is overwritten by the following variable defrag_count
>> and this assignment is useless, so remove it.
>
> This could be actually pointing to a bug, please explain why you think
> it's correct to remove it and not to return EAGAIN.
The right fix should be goto out_ra and return EAGAIN. I will do it
in the next version.
Thanks,
Kaixu
>
--
kaixuxia
prev parent reply other threads:[~2020-11-17 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 9:06 xiakaixu1987
2020-11-16 15:13 ` David Sterba
2020-11-17 2:53 ` kaixuxia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a60330f-ae5e-ba78-ef34-69ab2b7ee0df@gmail.com \
--to=xiakaixu1987@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kaixuxia@tencent.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®